Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:3734
Return-Path: <swalk@prp.physik.tu-darmstadt.de>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 25550 invoked from network); 5 Aug 2003 13:07:47 -0000
Received: from unknown (HELO prp0.prp.physik.tu-darmstadt.de) (130.83.243.130)
  by pb1.pair.com with SMTP; 5 Aug 2003 13:07:47 -0000
Received: from prp0.prp.physik.tu-darmstadt.de (localhost [127.0.0.1])
	by prp0.prp.physik.tu-darmstadt.de (8.12.3/8.12.3/SuSE Linux 0.6) with ESMTP id h75D7jE7001579;
	Tue, 5 Aug 2003 15:07:45 +0200
Received: (from swalk@localhost)
	by prp0.prp.physik.tu-darmstadt.de (8.12.3/8.12.3/Submit) id h75D7jqD001578;
	Tue, 5 Aug 2003 15:07:45 +0200
Date: Tue, 5 Aug 2003 15:07:45 +0200
To: Jani Taskinen <sniper@iki.fi>
Cc: internals@lists.php.net
Message-ID: <20030805130745.GA1362@prp0.prp.physik.tu-darmstadt.de>
References: <20030805071448.GB29823@prp0.prp.physik.tu-darmstadt.de> <Pine.LNX.4.44.0308051532150.4674-100000@netphobia.fi>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Pine.LNX.4.44.0308051532150.4674-100000@netphobia.fi>
User-Agent: Mutt/1.3.27i
Subject: Re: [PHP-DEV] [PATCH] Repost: html_errors more readable
From: et@php.net (Stefan Walk)

On Tue, Aug 05, 2003 at 03:32:54PM +0300, Jani Taskinen wrote:
>     Why don't you just use the existing ini options:
>         
>     ; String to output before an error message.
>     ;error_prepend_string = "<font color=ff0000>"
>     
>     ; String to output after an error message.
>     ;error_append_string = "</font>"
>     
>     ??
>     
>     --Jani

This patch is not for me, I don't debug in my browser. While helping
others writing PHP,  the conversation "What error message?"
"There is none, look for yourself, http://..." was not rare, because the
error message was hidden somewhere.

Changing the default to display it in a well-formatted way would be
helpful for beginners, in my - and most people i asked about this -
opinion.

When changing append/prepend strings, they get outputted also when
html_errors is off, so putting html in them is not a good thing imo.
(Also, distinct colors are not possible by doing that).

Regards,
Stefan Walk