Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:37217
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain realplain.com from 209.151.69.1 cause and error)
Message-ID: <018601c8a6e9$54fb8660$0201a8c0@pc1>
To: <internals@lists.php.net>,
	"Andrey Hristov" <php@hristov.com>
References: <014b01c8a6db$57d53ba0$0201a8c0@pc1> <4811E99B.6020004@hristov.com>
Date: Fri, 25 Apr 2008 10:30:43 -0500
MIME-Version: 1.0
Content-Type: text/plain;
	charset="Windows-1252"
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] [PATCH] More array filling optimizations
From: php_lists@realplain.com ("Matt Wilmas")

Hi Andrey,

----- Original Message -----
From: "Andrey Hristov"
Sent: Friday, April 25, 2008

>   Hi,
> [...]
> heh, this optimisitations was one of the pluses mysqlnd had over
> mysqli/libmysql. I am using the following macro:
>
> #if PHP_MAJOR_VERSION < 6
> #define mysqlnd_array_init(arg, field_count) \
> { \
> ALLOC_HASHTABLE_REL(Z_ARRVAL_P(arg));\
> zend_hash_init(Z_ARRVAL_P(arg), (field_count), NULL, ZVAL_PTR_DTOR, 0); \
> Z_TYPE_P(arg) = IS_ARRAY;\
> }
> #else
> #define mysqlnd_array_init(arg, field_count) \
> { \
> ALLOC_HASHTABLE_REL(Z_ARRVAL_P(arg));\
> zend_u_hash_init(Z_ARRVAL_P(arg), (field_count), NULL, ZVAL_PTR_DTOR,
> 0, 0);\
> Z_TYPE_P(arg) = IS_ARRAY;\
> }
> #endif
>

Ah yes, I see. :-)  Yeah, any of the database functions (in all DB exts.)
that create/return arrays are one of the obvious things I had in mind to
change, but hadn't come across your mysqlnd "workaround," heh.  Just knew
that plain array_init() is used in mysql/mysqli, pgsql, sqlite, etc...


- Matt