Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:37181
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain macvicar.net from 72.232.140.210 cause and error)
Message-ID: <480E2848.3070400@macvicar.net>
Date: Tue, 22 Apr 2008 19:02:48 +0100
User-Agent: Thunderbird 2.0.0.12 (Windows/20080213)
MIME-Version: 1.0
To: jani.taskinen@iki.fi
CC: RQuadling@GoogleMail.com, 
 PHP Developers Mailing List <internals@lists.php.net>
References: <10845a340804170743w3ebd165v5ffd7af28168113b@mail.gmail.com>	 <480781E0.3060805@macvicar.net> <1208452764.10595.10.camel@localhost.localdomain>
In-Reply-To: <1208452764.10595.10.camel@localhost.localdomain>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] Win32 mail() issue and potential fix - needs better
 brains than me to verify solution.
From: scott@macvicar.net (Scott MacVicar)

Jani Taskinen wrote:
> On Thu, 2008-04-17 at 17:59 +0100, Scott MacVicar wrote:
>> Hi Richard,
>>
>> The patch would fix it in this case but there is an underlying change 
>> that needs sorted.
>>
>> zend_ini_string()'s behaviour was changed to fix 
>> http://bugs.php.net/bug.php?id=42657 so that if the default value was 
>> NULL it would then return an empty string instead.
>>
>> http://cvs.php.net/viewvc.cgi/ZendEngine2/zend_ini.c?r1=1.39.2.2.2.18.2.6&r2=1.39.2.2.2.18.2.7
>>
>> This broke the places that were relying on INI_STR returning the NULL?
> 
> Propably, but INI_STR is evil and should never be used anyway. 
> 
>> Should this fix be backed out and change ini_get and ini_set to deal 
>> with this for the userland?
> 
> Hell no. Fix places using INI_STR incorrectly instead.
> (as in: make them NOT use INI_STR.. :)
> 
> --Jani
> 
> 
> 

What is the alternative to INI_STR if you just want the value?

Scott