Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:37174 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 68597 invoked from network); 22 Apr 2008 15:37:12 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 22 Apr 2008 15:37:12 -0000 Authentication-Results: pb1.pair.com header.from=rquadling@googlemail.com; sender-id=pass; domainkeys=bad Authentication-Results: pb1.pair.com smtp.mail=rquadling@googlemail.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain googlemail.com designates 209.85.146.181 as permitted sender) DomainKey-Status: bad X-DomainKeys: Ecelerity dk_validate implementing draft-delany-domainkeys-base-01 X-PHP-List-Original-Sender: rquadling@googlemail.com X-Host-Fingerprint: 209.85.146.181 wa-out-1112.google.com Received: from [209.85.146.181] ([209.85.146.181:4497] helo=wa-out-1112.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 6F/E1-59922-7260E084 for ; Tue, 22 Apr 2008 11:37:12 -0400 Received: by wa-out-1112.google.com with SMTP id l24so3503527waf.17 for ; Tue, 22 Apr 2008 08:37:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:reply-to:to:subject:mime-version:content-type; bh=ycjcyUNUwyjy3gTuQlXVzwqEch91YhWJ8jjOHG4Zc2s=; b=wQYjXH6r2ubJonOc5q0abZm/s9du0uzbcCBzxrI3aKrG7nhzeosKArSwJITGwLkvy7R+uQO4RYKyN9uuZrjsi1EIz20HCE9CeIV7xtdD09q4SSoENSjiGmU+h+dr3k69gY+/ufsUMURgxXWQdQQZOOYU6SOvep55kevjHaw6a6I= DomainKey-Signature: a=rsa-sha1; c=nofws; d=googlemail.com; s=gamma; h=message-id:date:from:reply-to:to:subject:mime-version:content-type; b=q9Ni7mBrspaztNdGOjgSP5BMnfsUP7siiHQmWxv1r1zfRTOv4Ddj5orWaF38zwdZDCVN7oVIj6ln5hjitHoM3U2PegOCJXvN4mM0yaAhq0zKy9VUMw0w0JaIvSFudoCqUUSkf9tYHCGP0dqStbgZrKhtRdXESbJYrFto6n1mOSg= Received: by 10.114.37.1 with SMTP id k1mr456640wak.6.1208878627786; Tue, 22 Apr 2008 08:37:07 -0700 (PDT) Received: by 10.114.209.15 with HTTP; Tue, 22 Apr 2008 08:37:07 -0700 (PDT) Message-ID: <10845a340804220837w4037d72fw1e291f89d2feee19@mail.gmail.com> Date: Tue, 22 Apr 2008 16:37:07 +0100 Reply-To: RQuadling@GoogleMail.com To: "PHP Developers Mailing List" MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_22462_27207212.1208878627773" Subject: Recent readdir.h From: rquadling@googlemail.com ("Richard Quadling") ------=_Part_22462_27207212.1208878627773 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Content-Disposition: inline Hi. The recent commit to TSRM/readdir.h isn't quite right. The later versions of the MS VC compiler set _WINNT32_WINNT to 0x600. This causes problems later on in fopen_wrappers.c fopen_wrappers.c C:\Program Files\Microsoft SDKs\Windows\v6.1\include\ws2tcpip.h(583) : error C2373: 'inet_pton' : redefinition; different type modifiers ..\php_build\include\arpa/inet.h(96) : see declaration of 'inet_pton' C:\Program Files\Microsoft SDKs\Windows\v6.1\include\ws2tcpip.h(600) : error C2373: 'inet_ntop' : redefinition; different type modifiers ..\php_build\include\arpa/inet.h(97) : see declaration of 'inet_ntop' Changing readdir.h so that it simply undef _WIN32_WINNT first, preserves PHP's value for this constant. I've attached patches for 5.3 and head (HEAD is untested). By adding and removing the patches, I can get 5.3 to compile or not. This will only be a problem when using a MS compiler which supplies a _WIN32_WINNT > 0x0400. And as I'm following the new PHP documentation on compiling PHP for windows, I hope this gets in. Regards, Richard. -- ----- Richard Quadling Zend Certified Engineer : http://zend.com/zce.php?c=ZEND002498&r=213474731 "Standing on the shoulders of some very clever giants!" ------=_Part_22462_27207212.1208878627773--