Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:37168
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain macvicar.net from 72.232.140.210 cause and error)
Message-ID: <480DD9B5.3070904@macvicar.net>
Date: Tue, 22 Apr 2008 13:27:33 +0100
User-Agent: Thunderbird 2.0.0.12 (Windows/20080213)
MIME-Version: 1.0
To: RQuadling@GoogleMail.com
CC: Antony Dovgal <tony@daylessday.org>, 
 PHP Developers Mailing List <internals@lists.php.net>
References: <10845a340804220401j48f63d18v989a72706951a495@mail.gmail.com>	 <480DD36C.8090701@daylessday.org> <10845a340804220523ued5f4e3ge2c7e21e94f249bb@mail.gmail.com>
In-Reply-To: <10845a340804220523ued5f4e3ge2c7e21e94f249bb@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] Building PHP. Clean builds. Noisy redefines.
From: scott@macvicar.net (Scott MacVicar)

Richard Quadling wrote:
> On 22/04/2008, Antony Dovgal <tony@daylessday.org> wrote:
>> On 22.04.2008 15:01, Richard Quadling wrote:
>>
>>> Another warning is that some of the constants are redefined to a
>>> different value from the ones that are part of the compiler. The
>>> /TRSM/readdir.h, _WIN32_WINNT is redefined from 0x0600 in C:\Program
>>> Files\Microsoft
>> SDKs\Windows\v6.1\include\sdkddkver.h(186).
>>> This 1 #define causes a LOT of noise during compilation. I know I
>>> could suppress all the warnings, but with so much noise, how does
>>> anyone see the true warnings in the noise?
>>>
>>> By adding a #undef _WIN32_WINNT before #define _WIN32_WINNT 0x0400,
>>> this removes the warning.  It is more or less every .c compile.
>>>
>>  http://dev.daylessday.org/diff/readdir_winnt.diff
>>  Did I get you right ?
>>
>>  --
>>  Wbr, Antony Dovgal
>>
> 
> Yes on the patch. There are a few more like this. It is just a cosmetic issue.
> 
> I am using Microsoft Visual C++ 2008 Express Edition with the Windows
> Server 2008 and .NET 3.4 SDK.
> 
> I'm NOT running Apache (so runtime version issues there don't apply),
> and I am only playing/learning - this is going nowhere near my
> live/dev servers. Just learning.
> 
> 
> My next goal is to get a version of Linux so I can build and test my
> suggestions on 2 platforms. Hopefully, my patches/suggestions will
> have more support!
> 
> Thank you.
> 
> Richard.
> 
> 

I applied something slightly different, the define is only needed for 
old versions of Windows that lack it.

Scott