Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:37162
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Message-ID: <77.90.39257.8A1DD084@pb1.pair.com>
To: internals@lists.php.net
Date: Tue, 22 Apr 2008 07:53:09 -0400
User-Agent: Thunderbird 2.0.0.12 (Windows/20080213)
MIME-Version: 1.0
References: <10845a340804220401j48f63d18v989a72706951a495@mail.gmail.com>
In-Reply-To: <10845a340804220401j48f63d18v989a72706951a495@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: Building PHP. Clean builds. Noisy redefines.
From: auroraeosrose@gmail.com (Elizabeth M Smith)

Richard Quadling wrote:
> Hi.
> 
> Probably much to all your annoyance, I've finally managed to compile
> PHP on windows and I have a few questions.I'm very much just learning.
> 
> 
> I notice that there are a LOT of warnings when I'm compiling. The huge
> majority are benign.
> 
> But, is there a reason to not fix the issue and make the code unambiguous?
> 
> Things like (just grabbed from screen) ...
> 
> main\streams\userspace.c(823) : warning C4244: '=' : conversion from
> 'long' to '_ino_t', possible loss of data
> main\streams\userspace.c(824) : warning C4244: '=' : conversion from
> 'long' to 'unsigned short', possible loss of data
> main\streams\userspace.c(825) : warning C4244: '=' : conversion from
> 'long' to 'short', possible loss of data
> 
> The way I look at this, is that a long was used for some reason, so,
> theoretically, it could hold a value which cannot be converted to the
> destination type without a problem.
> 
> 
> Another warning is that some of the constants are redefined to a
> different value from the ones that are part of the compiler. The
> /TRSM/readdir.h, _WIN32_WINNT is redefined from 0x0600 in C:\Program
> Files\Microsoft SDKs\Windows\v6.1\include\sdkddkver.h(186).
> 
> This 1 #define causes a LOT of noise during compilation. I know I
> could suppress all the warnings, but with so much noise, how does
> anyone see the true warnings in the noise?
> 
> By adding a #undef _WIN32_WINNT before #define _WIN32_WINNT 0x0400,
> this removes the warning.  It is more or less every .c compile.
> 
> Regards,
> 
> Richard Quadling.
> 
Hmmm - I don't get the first set of long to short warnings - what
compiler/sdk are you using?  Second set of (highly annoying) warnings is
due to a file in TSRM - in readdir.h - and I'd love to have fixed but
there is a very small set of people with karma there and even fewer who
care about windows compiler warnings.

Thanks,
Elizabeth Smith