Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:37160
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain googlemail.com designates 64.233.184.236 as permitted sender)
DomainKey-Status: bad
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=googlemail.com; s=gamma;
        h=message-id:date:from:reply-to:to:subject:mime-version:content-type:content-transfer-encoding:content-disposition;
        b=AvisrxihA2PmXRWaEDn335VSt2Z/5mz3oL1nq7y80WRtWLfB2JfdGa1V21athPI2an3dMlPH+JJu4jeQZT2FVDKYXW5COgglXyR68QwnDROBbZ2w4phDdzyaPfsLHLveY4MbD2XiywqKThKPWoSQZM/YsJlZQO3LcAM+szEfkzQ=
Message-ID: <10845a340804220401j48f63d18v989a72706951a495@mail.gmail.com>
Date: Tue, 22 Apr 2008 12:01:05 +0100
Reply-To: RQuadling@GoogleMail.com
To: "PHP Developers Mailing List" <internals@lists.php.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Subject: Building PHP. Clean builds. Noisy redefines.
From: rquadling@googlemail.com ("Richard Quadling")

Hi.

Probably much to all your annoyance, I've finally managed to compile
PHP on windows and I have a few questions.I'm very much just learning.


I notice that there are a LOT of warnings when I'm compiling. The huge
majority are benign.

But, is there a reason to not fix the issue and make the code unambiguous?

Things like (just grabbed from screen) ...

main\streams\userspace.c(823) : warning C4244: '=' : conversion from
'long' to '_ino_t', possible loss of data
main\streams\userspace.c(824) : warning C4244: '=' : conversion from
'long' to 'unsigned short', possible loss of data
main\streams\userspace.c(825) : warning C4244: '=' : conversion from
'long' to 'short', possible loss of data

The way I look at this, is that a long was used for some reason, so,
theoretically, it could hold a value which cannot be converted to the
destination type without a problem.


Another warning is that some of the constants are redefined to a
different value from the ones that are part of the compiler. The
/TRSM/readdir.h, _WIN32_WINNT is redefined from 0x0600 in C:\Program
Files\Microsoft SDKs\Windows\v6.1\include\sdkddkver.h(186).

This 1 #define causes a LOT of noise during compilation. I know I
could suppress all the warnings, but with so much noise, how does
anyone see the true warnings in the noise?

By adding a #undef _WIN32_WINNT before #define _WIN32_WINNT 0x0400,
this removes the warning.  It is more or less every .c compile.

Regards,

Richard Quadling.

-- 
-----
Richard Quadling
Zend Certified Engineer : http://zend.com/zce.php?c=ZEND002498&r=213474731
"Standing on the shoulders of some very clever giants!"