Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:37093 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 26074 invoked from network); 17 Apr 2008 17:19:32 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 17 Apr 2008 17:19:32 -0000 Authentication-Results: pb1.pair.com smtp.mail=jani.taskinen@sci.fi; spf=permerror; sender-id=unknown Authentication-Results: pb1.pair.com header.from=jani.taskinen@sci.fi; sender-id=unknown Received-SPF: error (pb1.pair.com: domain sci.fi from 63.208.196.179 cause and error) X-PHP-List-Original-Sender: jani.taskinen@sci.fi X-Host-Fingerprint: 63.208.196.179 mho-02-bos.mailhop.org Received: from [63.208.196.179] ([63.208.196.179:52914] helo=mho-02-bos.mailhop.org) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 0F/E9-05127-2A687084 for ; Thu, 17 Apr 2008 13:19:31 -0400 Received: from [81.22.163.71] (helo=[10.6.109.198]) by mho-02-bos.mailhop.org with esmtpsa (SSLv3:RC4-MD5:128) (Exim 4.68) (envelope-from ) id 1JmXle-0003wM-P7; Thu, 17 Apr 2008 17:19:27 +0000 X-Mail-Handler: MailHop Outbound by DynDNS X-Originating-IP: 81.22.163.71 X-Report-Abuse-To: abuse@dyndns.com (see http://www.mailhop.org/outbound/abuse.html for abuse reporting information) X-MHO-User: U2FsdGVkX19MdTx/OYWOxePgufF0jjsHuc1+zYuVIYU= Reply-To: jani.taskinen@iki.fi To: Scott MacVicar Cc: RQuadling@GoogleMail.com, PHP Developers Mailing List , jani.taskinen@iki.fi In-Reply-To: <480781E0.3060805@macvicar.net> References: <10845a340804170743w3ebd165v5ffd7af28168113b@mail.gmail.com> <480781E0.3060805@macvicar.net> Content-Type: text/plain Date: Thu, 17 Apr 2008 20:19:24 +0300 Message-ID: <1208452764.10595.10.camel@localhost.localdomain> Mime-Version: 1.0 X-Mailer: Evolution 2.8.3 (2.8.3-2.fc6) Content-Transfer-Encoding: 7bit Subject: Re: [PHP-DEV] Win32 mail() issue and potential fix - needs better brains than me to verify solution. From: jani.taskinen@sci.fi (Jani Taskinen) On Thu, 2008-04-17 at 17:59 +0100, Scott MacVicar wrote: > Hi Richard, > > The patch would fix it in this case but there is an underlying change > that needs sorted. > > zend_ini_string()'s behaviour was changed to fix > http://bugs.php.net/bug.php?id=42657 so that if the default value was > NULL it would then return an empty string instead. > > http://cvs.php.net/viewvc.cgi/ZendEngine2/zend_ini.c?r1=1.39.2.2.2.18.2.6&r2=1.39.2.2.2.18.2.7 > > This broke the places that were relying on INI_STR returning the NULL? Propably, but INI_STR is evil and should never be used anyway. > Should this fix be backed out and change ini_get and ini_set to deal > with this for the userland? Hell no. Fix places using INI_STR incorrectly instead. (as in: make them NOT use INI_STR.. :) --Jani