Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:37061
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.146.182 as permitted sender)
DomainKey-Status: bad
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references;
        b=AkY2vGxaKbyfZ8om4MJTkW918xC7XWQusIWXi9Bwg6cCA7uNkUVmemO2jsMCkq+FYl6lx0NwNsLogY307eCxjgggwHcKwZaizVHNQqLnePSsYaAAHDXO608i2JN5pfVf6w0c0LdCB4skBPESD9RCAPIJTgahuo4J6N3Mve2gfuI=
Message-ID: <af54caaf0804170552vf0e0ddep7b57f6a362ffa35d@mail.gmail.com>
Date: Thu, 17 Apr 2008 14:52:32 +0200
To: "Felipe Pena" <felipensp@gmail.com>
Cc: internals@lists.php.net
In-Reply-To: <1208404255.5665.34.camel@pena>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <1208404255.5665.34.camel@pena>
Subject: Re: [PHP-DEV] [RFC] Type hints (parameter and return value)
From: paul.biggar@gmail.com ("Paul Biggar")

Hi,

Your current implementation seems to be inconsistent with both itself
and the rest of PHP. I hope this can be rectified before it is
included. PHP is inconsisent enough without adding more.


1.) There are a number of is_* functions. It seems obvious that they
should be consistent with this. So you're missing numeric and scalar.
I'm not clear if there is a is_unicode(), but if so, that should be
consistent too. (I believe scalar is particularly important, at a
language level, since mixed and object are provided).

2.) is_int has different semantics to the int type hint. Numeric
strings qualify as the latter, but not the former. In general this is
a problem. It seems type hints can only be made consistent if they
convert the actual parameter to the type which is hinted. (Note that
for call-by-reference, this will change the value in the caller, not
just the copy in the callee - I think this is a good idea). As an
example, this will fail, which it shouldnt: function y (int $x) {
assert (is_int($x); } y ("24");

3.) This doesnt seem to be integrated with class type hints, in the
codebase. I wonder why that is? (I don't care all that much, I'm just
wondering).

I hope we can get these ironed out.

Thanks in advance.
Paul


On Thu, Apr 17, 2008 at 5:50 AM, Felipe Pena <felipensp@gmail.com> wrote:
> Hello again!
>
>  Now with both parameter and return value type hints.
>
>  For parameter type hints, i have completed the actual implementation
>  with the leftover php types:
>  - string (binary string and unicode)
>  - integer (accepting numeric string too)
>  - double (accepting numeric string too)
>  - boolean ('0', '1', true, false)
>  - resource
>  - object
>
>  (Yes, following our dynamic typing)
>
>
>  Since then, the patch also includes new methods to Reflection:
>  - isInt()
>  - isDouble()
>  - isBool()
>  - isString()
>  - isObject()
>  - isResource()
>
>
>  And for return value, i have modified and improved the previous patch,
>  and now it is using only the "(type)" notation. Hence, that
>  implementation doesn't make any BC break.
>
>
>  Examples, patches and tests: http://wiki.php.net/rfc/typehint
>
>
>  Thanks.
>
>  --
>  Regards,
>  Felipe Pena.
>
>
>  --
>  PHP Internals - PHP Runtime Development Mailing List
>  To unsubscribe, visit: http://www.php.net/unsub.php
>
>



-- 
Paul Biggar
paul.biggar@gmail.com