Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:37056
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain cschneid.com from 195.141.85.117 cause and error)
Message-ID: <48073922.6030808@cschneid.com>
Date: Thu, 17 Apr 2008 13:48:50 +0200
User-Agent: Thunderbird 1.5.0.12 (X11/20060911)
MIME-Version: 1.0
To: Felipe Pena <felipensp@gmail.com>
CC:  internals@lists.php.net
References: <1208404255.5665.34.camel@pena>
In-Reply-To: <1208404255.5665.34.camel@pena>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [RFC] Type hints (parameter and return value)
From: cschneid@cschneid.com (Christian Schneider)

Felipe Pena wrote:
> For parameter type hints, i have completed the actual implementation
> with the leftover php types:
> - string (binary string and unicode)
> - integer (accepting numeric string too)
> - double (accepting numeric string too)
> - boolean ('0', '1', true, false)
> - resource
> - object

I don't like the difference between
	function (int) test($value) { ... }
and
	function test(integer $value) { ... }

I don't think we should introduce two different names for something
which is basically the same. Even if there is (as I guess) a slight
difference (int *really* being int and integer allowing strings
containing numbers), which makes the WTF factor even higher IMHO.

Also about "New tokens (new keywords)": I haven't tried the patch so
excuse me asking. Does this mean $this->string is invalid because string
is a new keyword? Then I'd be strongly against having these new keywords.

Is there any performance impact for people not using type hints?

Just to make it clear: I think type hinting is a Bad Idea(tm) anyway but
*if* it is implemented I think you should consider the above points.

- Chris