Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:36996 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 71673 invoked from network); 14 Apr 2008 07:37:04 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 14 Apr 2008 07:37:04 -0000 Authentication-Results: pb1.pair.com header.from=pierre.php@gmail.com; sender-id=pass; domainkeys=bad Authentication-Results: pb1.pair.com smtp.mail=pierre.php@gmail.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.198.228 as permitted sender) DomainKey-Status: bad X-DomainKeys: Ecelerity dk_validate implementing draft-delany-domainkeys-base-01 X-PHP-List-Original-Sender: pierre.php@gmail.com X-Host-Fingerprint: 209.85.198.228 rv-out-0506.google.com Received: from [209.85.198.228] ([209.85.198.228:29167] helo=rv-out-0506.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id A9/D1-61656-E9903084 for ; Mon, 14 Apr 2008 03:37:03 -0400 Received: by rv-out-0506.google.com with SMTP id g37so569787rvb.23 for ; Mon, 14 Apr 2008 00:37:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; bh=KI7BJ9pba90Jv/urslPkSNxodFHugD17leV+/aB+fcI=; b=nLpomzFuFHFB3FpHOFsYKwym5rzhTf8kwOZpX7qqY0sW6ApHnHKafIHaYXPaiRH0oegq1qDNtRkT+UIPJn7mChOEANk3CbV15lGB+3qXQrfhti+QLcpGAqs7b4efceCB5llXBKh+zjZcskNrzptYR/QNQNDsVZfC3W+z18AyNXw= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=c6Cv1BTe0o0veLxt4IlklExHRNCeRwdxdLp3FxxlrG+nv9omwk9ebLAnRRK556tDrLD/mO32X5xcNAfmqeZZ+wmlT1wWV9TeS8WT3+jMn+8vJwNsZfqZflbabNy+DcjKZue0fP/vsiTIjGGHNWXWp0VMOOZ4uW2gYtiZ7zBG0JI= Received: by 10.140.144.1 with SMTP id r1mr3172089rvd.10.1208158620484; Mon, 14 Apr 2008 00:37:00 -0700 (PDT) Received: by 10.141.123.13 with HTTP; Mon, 14 Apr 2008 00:37:00 -0700 (PDT) Message-ID: Date: Mon, 14 Apr 2008 09:37:00 +0200 To: "Gregory Beaver" Cc: "internals Mailing List" In-Reply-To: <4802868B.2030105@chiaraquartet.net> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <4802868B.2030105@chiaraquartet.net> Subject: Re: [PHP-DEV] php_stream_display_wrapper_errors issue From: pierre.php@gmail.com ("Pierre Joye") Hi Greg, On Mon, Apr 14, 2008 at 12:17 AM, Gregory Beaver wrote: > Hi, > > If a stream wrapper does not log errors, by default, we grab > strerror(errno) to figure out the error message, but this is not a good > idea for any wrapper but plain_wrapper for the obvious reason that errno > is not used by wrappers that don't use sys calls. > > Is this patch against 5.3 acceptable (I'll merge to HEAD on commit if so)? I think it fixes the possible misguided error messages. To go one step further, I wonder if it would make sense to add a stream_strno and stream_strerror to _php_stream_wrapper_ops. It may be helpful to display the actual error or for debugging purposes (user land or internally). Comments? Cheers, -- Pierre http://blog.thepimp.net | http://www.libgd.org