Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:36929 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 21157 invoked from network); 10 Apr 2008 19:43:07 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 10 Apr 2008 19:43:07 -0000 Authentication-Results: pb1.pair.com smtp.mail=pierre.php@gmail.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=pierre.php@gmail.com; sender-id=pass; domainkeys=bad Received-SPF: pass (pb1.pair.com: domain gmail.com designates 64.233.184.238 as permitted sender) DomainKey-Status: bad X-DomainKeys: Ecelerity dk_validate implementing draft-delany-domainkeys-base-01 X-PHP-List-Original-Sender: pierre.php@gmail.com X-Host-Fingerprint: 64.233.184.238 wr-out-0506.google.com Received: from [64.233.184.238] ([64.233.184.238:23910] helo=wr-out-0506.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 31/D0-32943-8CD6EF74 for ; Thu, 10 Apr 2008 15:43:05 -0400 Received: by wr-out-0506.google.com with SMTP id 50so167034wri.2 for ; Thu, 10 Apr 2008 12:43:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; bh=DFMVtfVNn0jmOf/HrR9uH4Sxwo0gn/v8KAmuPs/JfXo=; b=lnKIF2i3aTv84lYuqrAjIbiSsS7vtp7RM2sNGtmj77WBftHnWG4UQl1rFOLMjDJsy0HUVG+ZzzeMP5K6biqLn4HsrDJALUS3KydohDFvziHn5cwnYVEVbs3VXXqLyM378BH5bUyGpv+bBqHjTA2z8BCVe6ECj14j6kQUeVYDjaM= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=W+v0sggQXrcC/Dx8YwnyjHADHRhLikV55qjCRb/8Iu/ErLm80ZmpyNt4kYo5YpZpr60vlxfleEduwepN/IPle7iaoDXfjQPopbY9geCGsYa7iBmylVfEeznecMMmz8i0iotursJF5bgWn96ncQevwwpNewMyxTxfyWN8aE489Bc= Received: by 10.140.164.1 with SMTP id m1mr1016918rve.266.1207856581775; Thu, 10 Apr 2008 12:43:01 -0700 (PDT) Received: by 10.141.123.13 with HTTP; Thu, 10 Apr 2008 12:43:01 -0700 (PDT) Message-ID: Date: Thu, 10 Apr 2008 21:43:01 +0200 To: "Stanislav Malyshev" Cc: "PHP internals" In-Reply-To: <47FE6579.6090107@zend.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <47FCF547.2090802@zend.com> <47FE58C3.3040207@zend.com> <47FE6579.6090107@zend.com> Subject: Re: [PHP-DEV] intl win32, which ICU version and binaries? From: pierre.php@gmail.com ("Pierre Joye") On Thu, Apr 10, 2008 at 9:07 PM, Stanislav Malyshev wrote: > Hi! > > > > > UnicodeString::UnicodeString(unsigned short const *,int) seems > > actually wrong, for what I can see in the headers. There is no > > > > It builds on my machine. And it uses UnicodeString(UChar *, int) which > looks OK and ctor with this signature is defined in unistr.h. > > > > > it this way is correct, should you not use the UNICODE_STRING macro? > > > > Seems to be roughly the same... Ah? in 3.6/8 it takes three arguments on my architecture (win xp, 32bit mode with amd64). Which version do you use? The define: #if U_SIZEOF_WCHAR_T==U_SIZEOF_UCHAR && (U_CHARSET_FAMILY==U_ASCII_FAMILY || (U_SIZEOF_UCHAR == 2 && defined(U_WCHAR_IS_UTF16))) # define UNICODE_STRING(cs, _length) UnicodeString(TRUE, (const UChar *)L ## cs, _length) #elif U_SIZEOF_UCHAR==1 && U_CHARSET_FAMILY==U_ASCII_FAMILY # define UNICODE_STRING(cs, _length) UnicodeString(TRUE, (const UChar *)cs, _length) #else # define UNICODE_STRING(cs, _length) UnicodeString(cs, _length, US_INV) #endif Cheers, -- Pierre http://blog.thepimp.net | http://www.libgd.org