Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:36849 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 22230 invoked from network); 7 Apr 2008 15:20:48 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 7 Apr 2008 15:20:48 -0000 Authentication-Results: pb1.pair.com smtp.mail=hoffie@gentoo.org; spf=unknown; sender-id=unknown Authentication-Results: pb1.pair.com header.from=hoffie@gentoo.org; sender-id=unknown Received-SPF: unknown (pb1.pair.com: domain gentoo.org does not designate 217.20.118.221 as permitted sender) X-PHP-List-Original-Sender: hoffie@gentoo.org X-Host-Fingerprint: 217.20.118.221 217.20.118.221 Received: from [217.20.118.221] ([217.20.118.221:34077] helo=srv.hoffie.info) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 82/AF-50465-9CB3AF74 for ; Mon, 07 Apr 2008 11:20:44 -0400 Received: from [192.168.1.2] (p5494F3B7.dip.t-dialin.net [84.148.243.183]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by srv.hoffie.info (Postfix) with ESMTP id 6E3A85803F; Mon, 7 Apr 2008 17:20:36 +0200 (CEST) Message-ID: <47FA3BAD.3030808@gentoo.org> Date: Mon, 07 Apr 2008 17:20:13 +0200 User-Agent: Thunderbird 2.0.0.12 (X11/20080301) MIME-Version: 1.0 To: Josie Messa CC: PHP Developers Mailing List References: <47F94431.1020300@gentoo.org> In-Reply-To: X-Enigmail-Version: 0.95.6 OpenPGP: id=800DDCDE Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enigFF20A90C0C96E5C4FA070650" Subject: Re: [PHP-DEV] Small test case fixes / observations (php-5.2.6_rc4) From: hoffie@gentoo.org (Christian Hoffmann) --------------enigFF20A90C0C96E5C4FA070650 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: quoted-printable On 2008-04-07 11:22, Josie Messa wrote: > On Sun, Apr 6, 2008 at 10:44 PM, Christian Hoffmann = > wrote: >> while building and testing a minimal version of PHP and as such disabl= ing >> the session extension, I discovered that >> ext/standard/tests/general_functions/bug44394_2.phpt fails without the= >> session extension being enabled. I created a patch to fix that [1]. >> >> On a sidenote, some tests seem to break on amd64 systems: >> ext/standard/tests/array/array_slice_variation6.phpt: >> Apparently there is a real bug (or difference in behavior between 32bi= t >> and 64bit) in the code here, and the test revealed it. See [2] >> >> ext/standard/tests/array/array_slice_variation2.phpt >> ext/standard/tests/array/array_slice_variation3.phpt: >> Iteration 7 is different on 32bit and 64bit [3][4]. I don't know if th= is >> behavior is intended, for now I simply added a skipif for non-32bit [5= ][6]. >=20 >=20 > Ah, I wrote these tests on a 32 bit machine so I didn't pick up any ch= anges > in behaviour. I don't think a SKIPIF section should be added as I would= n't > expect there to be a difference here at all, and adding a SKIPIF sectio= n > means that the problem will get ignored, I'd raise a bug instead. Ok, thanks for looking into it. I filed bug 44664 [1] and would be happy = if the session fix could be committed (as I still think it is correct to = skip the test here). [1] http://bugs.php.net/bug.php?id=3D44664 --=20 Christian Hoffmann --------------enigFF20A90C0C96E5C4FA070650 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iEYEARECAAYFAkf6O8EACgkQV6E0EIywUuUPuQCfSaG+TbKo8M2B/032w8G2q8aG HIMAoJfHlCoxk8kyLvcoXQMRr58SjNzF =gNb4 -----END PGP SIGNATURE----- --------------enigFF20A90C0C96E5C4FA070650--