Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:36833
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain googlemail.com designates 72.14.220.158 as permitted sender)
DomainKey-Status: bad
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=googlemail.com; s=gamma;
        h=message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:references;
        b=G8wTqxnfgyKck3btTzto24J6vEA9pZkG8D7wctMz/kIV/ffIIUfO+p4a1bpfRxX4nnt1MH0+E/Odj01iTqNOZH091F8/3jESxSu3yVLpsO/NU43QFTUELOw26wn7M+ZpUzTo8wBhKFC4O3H9ur02b11UBIUbDw11dfL0Uhh5k1g=
Message-ID: <f29ac5f40804070222q7aa85113sedac0789f5ef92b6@mail.gmail.com>
Date: Mon, 7 Apr 2008 10:22:16 +0100
To: "Christian Hoffmann" <hoffie@gentoo.org>
Cc: "PHP Developers Mailing List" <internals@lists.php.net>
In-Reply-To: <47F94431.1020300@gentoo.org>
MIME-Version: 1.0
Content-Type: multipart/alternative; 
	boundary="----=_Part_178_21296428.1207560136087"
References: <47F94431.1020300@gentoo.org>
Subject: Re: [PHP-DEV] Small test case fixes / observations (php-5.2.6_rc4)
From: jdmessa@googlemail.com ("Josie Messa")

------=_Part_178_21296428.1207560136087
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

On Sun, Apr 6, 2008 at 10:44 PM, Christian Hoffmann <hoffie@gentoo.org>
wrote:

> Heya,
>
> while building and testing a minimal version of PHP and as such disabling
> the session extension, I discovered that
> ext/standard/tests/general_functions/bug44394_2.phpt fails without the
> session extension being enabled. I created a patch to fix that [1].
>
> On a sidenote, some tests seem to break on amd64 systems:
> ext/standard/tests/array/array_slice_variation6.phpt:
> Apparently there is a real bug (or difference in behavior between 32bit
> and 64bit) in the code here, and the test revealed it. See [2]
>
> ext/standard/tests/array/array_slice_variation2.phpt
> ext/standard/tests/array/array_slice_variation3.phpt:
> Iteration 7 is different on 32bit and 64bit [3][4]. I don't know if this
> behavior is intended, for now I simply added a skipif for non-32bit [5][6].


Ah, I wrote these  tests on a 32 bit machine so I didn't pick up any changes
in behaviour. I don't think a SKIPIF section should be added as I wouldn't
expect there to be a difference here at all, and adding a SKIPIF section
means that the problem will get ignored, I'd raise a bug instead.


>
>
> It would be nice to get the first patch (session-related), and maybe the
> 64bit-related skipifs as well, committed.
>
> All testing / patching has been done on/against php-5.2.6RC4.
>
> [1]
> http://home.hoffie.info/static/003_test-standard-bug44394_2-skipif.patch
> [2] http://home.hoffie.info/static/array_slice_variation6.diff
> [3] http://home.hoffie.info/static/array_slice_variation2.diff
> [4] http://home.hoffie.info/static/array_slice_variation3.diff
> [5]
> http://home.hoffie.info/static/005_test-standard-array_slice_variation2-32bitonly.patch
> [6]
> http://home.hoffie.info/static/004_test-standard-array_slice_variation3-32bitonly.patch
>
> Thanks,
> --
> Christian Hoffmann
>

Thanks,
Josie

------=_Part_178_21296428.1207560136087--