Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:36675
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: unknown (pb1.pair.com: domain php.net does not designate 85.214.94.56 as permitted sender)
Date: Sat, 29 Mar 2008 13:00:04 +0100
Reply-To: Marcus Boerger <helly@php.net>
Message-ID: <1703206313.20080329130004@marcus-boerger.de>
To: Elizabeth M Smith <auroraeosrose@gmail.com>, 
	"Gregory Beaver" <greg@chiaraquartet.net>
CC: internals@lists.php.net
In-Reply-To: <DB.A4.25926.9EF2DE74@pb1.pair.com>
References: <DA010320-E879-42BB-87BE-243CA34CBFE0@benjaminschulz.com>  <1206719555.6331.39.camel@localhost>  <07.8D.25926.CD81DE74@pb1.pair.com> <1206723693.6331.48.camel@localhost> <DB.A4.25926.9EF2DE74@pb1.pair.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: 8bit
Subject: Re: [PHP-DEV] phar API
From: helly@php.net (Marcus Boerger)

Hello Elizabeth,

Friday, March 28, 2008, 7:50:28 PM, you wrote:

>>> The only things I see missing are an addFile and addDirectory shortcut
>>> methods for when I don't want to mess with all the metadata or creating
>>> iterators.
>> 
>> addDirectory() is called createDirectory() in my RFC, just ignore the
>> return value. What would you like addFile() to do? Adding an empty file?
>> 
>> cu, Lars

> Not add an empty directory - just add a directory and its contents much
> like the Phar::create would do - an assumption that you want everything
> in that directory inside with no iterators or magic required.

> addFile(filename) would just add a file - no thinking required, although
> if there was an addDirectory you wouldn't really need it.

> I'm just of the opinion that the less I have to write for common actions
> the better.

> $phar = new Phar('/path/to/phar');
> if($phar->isWriteable())
> {
>         $phar->addDirectory('/path/to/some/stuff');
> }

A method named AddDirdectory() sounds very confusing to me as to me it
would just add an empty directory. So the thing you proposed should be
named addFromDirectory() which would be in line with buildFromIterator().
And in the end you could just use that with a DirectoryIterator.

$phar = new Phar('/path/to/phar');
if($phar->isWriteable())
{
      $phar->buildFromDirectory(new DirectoyIterator('/path/to/some/stuff'));
}

Now I am wondering only why we didn't do buildFromIterator() as a static
factory method and have the current one as addFromIterator().

Maybe you guys also want the *FromDirectory() versions?


Best regards,
 Marcus