Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:36673
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: unknown (pb1.pair.com: domain php.net does not designate 85.214.94.56 as permitted sender)
Date: Sat, 29 Mar 2008 12:45:09 +0100
Reply-To: Marcus Boerger <helly@php.net>
Message-ID: <1944269410.20080329124509@marcus-boerger.de>
To: Elizabeth M Smith <auroraeosrose@gmail.com>
CC: internals@lists.php.net
In-Reply-To: <24.59.25926.4B2ECE74@pb1.pair.com>
References: <DA010320-E879-42BB-87BE-243CA34CBFE0@benjaminschulz.com> <47EC1271.9020405@php.net> <24.59.25926.4B2ECE74@pb1.pair.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: 8bit
Subject: Re: [PHP-DEV] Re: phar API
From: helly@php.net (Marcus Boerger)

Hello Elizabeth,

Friday, March 28, 2008, 2:21:01 PM, you wrote:

> First of all Greg, thanks for all your hard work on phar - however I do
> agree that some of the API choices are going to cause confusion with
> "casual" phar users.

>> 1) if you want to know writability without Phar::canWrite(), you can
>> also use is_writeable('phar:///path/to/archive.phar/index.php') just
>> like you can with any other file

> However Phar::canWrite(); merely tells me if the readonly ini choice is
> flipped, correct? It doesn't relate to the actual file.  While the
> is_writeable function will do what I want for a specific file - I agree
> that a $phar->isWriteable() method would be a nicer (and more intuitive
> for the OO nuts) option.

You are right about Phar::canWrite() however there is also
Phar::isWriteable(). All we have to do is overload it correctly so that it
returns SplFileInfo::isWriteable() && Phar::canWrite().

>> 1) file_put_contents('phar:///path/to/archive.phar/index.php', 'file
>> contents');
>> 2) $phar = new Phar('/path/to/archive.phar');
>> $phar->buildFromIterator(new DirectoryIterator('/some/path'),
>> '/some/path');
>> 3) $phar = new Phar('/path/to/archive.phar'); $phar['index.php'] =
>> file_get_contents('/some/path/index.php');

> I don't know about you, but the common way I work with archives is to
> build a directory structure and just shove it into an archive wholesale
> - although the second option allows this - it's very verbose!  Any
> chance of a $phar = new Phar('/path/to/phar', '/path/to/archive');
> option for the lazy?  Or even a shortcut static
> Phar::create('/path/to/phar', '/path/to/archive') - and no I don't want
> to have to do an iterator too unless I'm worried about filtering what's
> going in, extra steps are usually not a good thing.  the option to have
> it is good, the choice to force it is not.

We liked the Phar::buildFromIterator() approach a lot :-)

Best regards,
 Marcus