Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:36665
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain zend.com from 64.97.136.143 cause and error)
Message-ID: <073401c89124$459482b0$4001a8c0@foxbox>
Reply-To: "Steph Fox" <steph@zend.com>
To: "Greg Beaver" <greg@chiaraquartet.net>,
	"php-dev" <internals@lists.php.net>,
	<lars@strojny.net>,
	"Elizabeth Smith" <emsmith@elizabethmariesmith.com>
References: <47ED6D97.3030109@chiaraquartet.net>
Date: Fri, 28 Mar 2008 22:37:02 -0000
Organization: Zend Technologies
MIME-Version: 1.0
Content-Type: text/plain;
	format=flowed;
	charset="iso-8859-1";
	reply-type=response
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] practical phar considerations
From: steph@zend.com ("Steph Fox")

Hi Greg,

> what benefit is there in adding complexity of remembering the Phar::GZ 
> constant over setCompressedGZ()?  We have to think hard about changes like 
> this.

We did think hard about them. In fact I thought you'd implemented 
compress(Phar::GZ) to replace the long-named one now :) Need to go play I 
guess.

> 3) I would like to suggest these changes, and these alone:
>
>  * simplify all compression methods, with more consistency of naming that 
> clearly differentiates between compressing files within an archive, and 
> compressing the entire archive.  This abstract idea is more important to 
> me than the specific naming, but it should be very easy to do.

Yep.

>  * add a zip-style API for adding files/directories, addFile, addEmptyDir, 
> addFileFromString with the exact method names

OK...

>  * add buildFromDirectory()

Cool...

>  * any further suggestions have off-list vetting with the maintainers of 
> phar for technical issues prior to publicly posting them, so we can truly 
> work together and present a more polished API suggestion to those 
> interested in phar on the first try without confusing them.  I am *NOT* 
> proposing we take discussion to private, only that technical issues be 
> worked out offlist prior to presenting an idea.
>
> Thank you for your patience, I know I am a bit of a hard-ass at times, but 
> I am genuinely excited about the discussion and creativity that is going 
> into this.
>
> Greg
>
> -- 
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>