Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:36660
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain zend.com from 64.97.136.150 cause and error)
Message-ID: <069801c890ff$607cf000$4001a8c0@foxbox>
Reply-To: "Steph Fox" <steph@zend.com>
To: <internals@lists.php.net>,
	"Elizabeth M Smith" <auroraeosrose@gmail.com>
References: <DA010320-E879-42BB-87BE-243CA34CBFE0@benjaminschulz.com>	 <1206719555.6331.39.camel@localhost>  <07.8D.25926.CD81DE74@pb1.pair.com> <1206723693.6331.48.camel@localhost> <DB.A4.25926.9EF2DE74@pb1.pair.com>
Date: Fri, 28 Mar 2008 18:13:06 -0000
Organization: Zend Technologies
MIME-Version: 1.0
Content-Type: text/plain;
	format=flowed;
	charset="iso-8859-1";
	reply-type=original
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] phar API
From: steph@zend.com ("Steph Fox")

Hi Elizabeth,

>>> The only things I see missing are an addFile and addDirectory shortcut
>>> methods for when I don't want to mess with all the metadata or creating
>>> iterators.
>>
>> addDirectory() is called createDirectory() in my RFC, just ignore the
>> return value. What would you like addFile() to do? Adding an empty file?
>>
>> cu, Lars
>
> Not add an empty directory - just add a directory and its contents much
> like the Phar::create would do - an assumption that you want everything
> in that directory inside with no iterators or magic required.

Hmm.. and how would you tell the difference between: empty directory 
creation, adding an existing directory plus contents, and whether the action 
is recursive or not? I think this needs a bit more thought.

> addFile(filename) would just add a file - no thinking required, although
> if there was an addDirectory you wouldn't really need it.

I think I'm probably missing something here... (haven't read the entire 
thread, can you tell?) addFile() in many cases would actually involve more 
typing than we do currently via array access...?

> I'm just of the opinion that the less I have to write for common actions
> the better.

Yes, I'm with you on that part. The main problem is that I don't know if 
Greg would want me or Marcus to add functionality (even aliasing-type 
shortcuts) this week, while we're in alpha. I rather suspect he'd like to 
leave edge-smoothing for 2.1.0 and just get the thing out there and tested 
ASAP, otherwise I'd be implementing everything Greg implemented last weekend 
right now :-)

We don't actually have missing functionality at this stage... everything 
mentioned here boils down to 'prettification'. So while it can definitely go 
down as 'wishlist' stuff, it's not actually essential.

- Steph