Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:36498
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain chiaraquartet.net from 38.99.98.18 cause and error)
Message-ID: <47E90886.4080806@chiaraquartet.net>
Date: Tue, 25 Mar 2008 09:13:26 -0500
User-Agent: Thunderbird 2.0.0.12 (X11/20080227)
MIME-Version: 1.0
To: Dmitry Stogov <dmitry@zend.com>
CC: Andi Gutmans <andi@zend.com>, 
 internals Mailing List <internals@lists.php.net>,
 Stas Malyshev <stas@zend.com>
References: <47E2F8FA.20107@chiaraquartet.net> <47E37C42.10308@zend.com> <698DE66518E7CA45812BD18E807866CE0165A762@us-ex1.zend.net> <47E8325C.5000901@chiaraquartet.net> <47E8C3EF.4080505@zend.com>
In-Reply-To: <47E8C3EF.4080505@zend.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] REMINDER - stream wrappers in include_path
From: greg@chiaraquartet.net (Gregory Beaver)

Dmitry Stogov wrote:
> I hope it's the last iteration, but check me anyway.
> The patch is based on latest Gregory's patch.
>
> - optimized out strncpy() calls
> - zend_resolve_path() replaced with php_resolve_path()
> - improved php_resolve_path() to resolve "file://..."
> - fixed possible double-free issue in _php_stream_open_wrapper_ex()
>
> Thanks. Dmitry.
>
> Greg Beaver wrote:
>> Andi Gutmans wrote:
>>> Can we please use strlcpy() instead of strncpy()? This is a coding
>>> standard we implemented years ago.
>>
>> obviously an easy change.  FYI - this also needs to be fixed in
>> fopen_with_path_rel in PHP_5_2, as I copied most of the code from
>> that function.
>>
>> Greg
works great here - commit with all due haste :)

Greg