Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:36483
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: unknown (pb1.pair.com: domain php.net does not designate 85.214.94.56 as permitted sender)
Date: Tue, 25 Mar 2008 11:27:57 +0100
Reply-To: Marcus Boerger <helly@php.net>
Message-ID: <505001029.20080325112757@marcus-boerger.de>
To: Dmitry Stogov <dmitry@zend.com>
CC: PHP Internals List <internals@lists.php.net>
In-Reply-To: <47E8D19C.6090608@zend.com>
References: <47E8D19C.6090608@zend.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: 8bit
Subject: Re: [PHP-DEV] re2c scanner issue
From: helly@php.net (Marcus Boerger)

Hello Dmitry,

Tuesday, March 25, 2008, 11:19:08 AM, you wrote:

> Hi Marcus,

> The ext/tokenizer/tests/token_get_all_variation17.phpt is probably the

There are probably more changes coming so there is not so much need to
change this part right now.

> last broken test. It has a memleak. I am not trying to fix it because 
> you should know it much better, also re2c scanner is not ported to HEAD 
> yet and you may keep changes that must be ported.

Yep we're aware of this. Right now Scott is doing the MFB to HEAD part and
last time I talked with him he made pretty good progress. I updated a lot
of stuff in re2c to give myself more freedom in how to address the task of
bringing back multibyte support back in. I also started on the PHP side and
fixed quite a bunch of issues in the multibyte code so far. The good news
is that my normal build still works as expected.

> BTW PHP_5_3 became faster. Good work!

Good to hear from others. Did you do any profiling you could share?

Best regards,
 Marcus