Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:36437
Return-Path: <andrei@gravitonic.com>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 68551 invoked from network); 24 Mar 2008 16:55:44 -0000
Received: from unknown (HELO lists.php.net) (127.0.0.1)
  by localhost with SMTP; 24 Mar 2008 16:55:44 -0000
Authentication-Results: pb1.pair.com smtp.mail=andrei@gravitonic.com; spf=permerror; sender-id=unknown
Authentication-Results: pb1.pair.com header.from=andrei@gravitonic.com; sender-id=unknown
Received-SPF: error (pb1.pair.com: domain gravitonic.com from 66.249.82.224 cause and error)
X-PHP-List-Original-Sender: andrei@gravitonic.com
X-Host-Fingerprint: 66.249.82.224 wx-out-0506.google.com  
Received: from [66.249.82.224] ([66.249.82.224:2621] helo=wx-out-0506.google.com)
	by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP
	id 18/FC-04656-F0DD7E74 for <internals@lists.php.net>; Mon, 24 Mar 2008 11:55:43 -0500
Received: by wx-out-0506.google.com with SMTP id s14so3072411wxc.26
        for <internals@lists.php.net>; Mon, 24 Mar 2008 09:55:41 -0700 (PDT)
Received: by 10.141.146.4 with SMTP id y4mr2344892rvn.272.1206377740644;
        Mon, 24 Mar 2008 09:55:40 -0700 (PDT)
Received: from Macintosh-5.local ( [206.15.64.202])
        by mx.google.com with ESMTPS id f36sm905251rvb.4.2008.03.24.09.55.38
        (version=TLSv1/SSLv3 cipher=RC4-MD5);
        Mon, 24 Mar 2008 09:55:39 -0700 (PDT)
Message-ID: <47E7DD09.2050006@gravitonic.com>
Date: Mon, 24 Mar 2008 09:55:37 -0700
User-Agent: Thunderbird 2.0.0.6 (Macintosh/20070807)
MIME-Version: 1.0
To: Geoffrey Sneddon <foolistbar@googlemail.com>
CC: Antony Dovgal <tony@daylessday.org>, 
 Stephen Bach <stephen@stephenbach.net>,
  internals@lists.php.net
References: <200803172351.12440.stephen@stephenbach.net> <47E3A581.9040107@daylessday.org> <3A27DFE4-DA24-4A14-8E65-8177F5A366AE@googlemail.com>
In-Reply-To: <3A27DFE4-DA24-4A14-8E65-8177F5A366AE@googlemail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] [PATCH] Bug 43477 - Unicode error mode ignored
From: andrei@gravitonic.com (Andrei Zmievski)

Where is the patch?

Geoffrey Sneddon wrote:
> 
> On 21 Mar 2008, at 12:09, Antony Dovgal wrote:
> 
>> On 03/18/2008 06:51 AM, Stephen Bach wrote:
>>> Attached is a simple proposed patch that fixes Bug 43477. Basically, 
>>> the code
>>> that set the error mode of the ICU converter was giving it an 
>>> instruction
>>> (the context parameter) to only skip or substitute if the code point 
>>> was not
>>> represented in the new encoding. However, it still was returning an 
>>> error for
>>> illegal sequences.
>>>
>>> The test suite returns the same results with or without the patch. 
>>> Test also
>>> attached.
>>
>> Patch committed, thanks.
> 
> Can we test U_CONV_ERROR_SUBST too? See attached patch. Also, the bug 
> should be closed.
> 
> 
> -- 
> Geoffrey Sneddon
> <http://gsnedders.com/>
> 
>