Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:36239 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 46007 invoked from network); 21 Mar 2008 16:57:33 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 21 Mar 2008 16:57:33 -0000 Authentication-Results: pb1.pair.com smtp.mail=stephen@stephenbach.net; spf=permerror; sender-id=unknown Authentication-Results: pb1.pair.com header.from=stephen@stephenbach.net; sender-id=unknown Received-SPF: error (pb1.pair.com: domain stephenbach.net from 208.113.200.5 cause and error) X-PHP-List-Original-Sender: stephen@stephenbach.net X-Host-Fingerprint: 208.113.200.5 lax-green-bigip-5.dreamhost.com Linux 2.4/2.6 Received: from [208.113.200.5] ([208.113.200.5:48779] helo=blingymail-a1.g.dreamhost.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 42/53-26785-CF8E3E74 for ; Fri, 21 Mar 2008 11:57:32 -0500 Received: from [192.168.1.102] (c-76-116-9-78.hsd1.nj.comcast.net [76.116.9.78]) by blingymail-a1.g.dreamhost.com (Postfix) with ESMTP id 8C13A5CC17; Fri, 21 Mar 2008 09:57:28 -0700 (PDT) To: Antony Dovgal Date: Fri, 21 Mar 2008 12:57:26 -0400 User-Agent: KMail/1.9.6 References: <200803172351.12440.stephen@stephenbach.net> <3A27DFE4-DA24-4A14-8E65-8177F5A366AE@googlemail.com> <47E3DD0A.5060208@daylessday.org> In-Reply-To: <47E3DD0A.5060208@daylessday.org> Cc: Geoffrey Sneddon , internals@lists.php.net MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-ID: <200803211257.27271.stephen@stephenbach.net> Subject: Re: [PHP-DEV] [PATCH] Bug 43477 - Unicode error mode ignored From: stephen@stephenbach.net (Stephen Bach) The original patch works as it should. Substitution with user-defined characters only works in the "FROM_UNICODE" case. When converting to Unicode, U+FFFD is always substituted because it is the standard substitution character. Even the ICU library does not allow this to be changed (with good reason). As for the test, *I think* the testing script would have to be Unicode-compatible and the test script would have to be in some UTF encoding to verify that U+FFFD was substituted. I don't know if this is the case yet. On Friday 21 March 2008 12:06:34 pm you wrote: > On 03/21/2008 06:28 PM, Geoffrey Sneddon wrote: > >> Patch committed, thanks. > > > > Can we test U_CONV_ERROR_SUBST too? See attached patch. Also, the bug > > should be closed. > > The patch breaks the test. > > Can you guys decide on what should work and how, I'll commit the patch > afterwards, ok?