Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:36233 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 24941 invoked from network); 21 Mar 2008 15:28:58 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 21 Mar 2008 15:28:58 -0000 Authentication-Results: pb1.pair.com smtp.mail=foolistbar@googlemail.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=foolistbar@googlemail.com; sender-id=pass Received-SPF: pass (pb1.pair.com: domain googlemail.com designates 66.249.92.169 as permitted sender) X-PHP-List-Original-Sender: foolistbar@googlemail.com X-Host-Fingerprint: 66.249.92.169 ug-out-1314.google.com Received: from [66.249.92.169] ([66.249.92.169:1156] helo=ug-out-1314.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 80/4E-42510-834D3E74 for ; Fri, 21 Mar 2008 10:28:57 -0500 Received: by ug-out-1314.google.com with SMTP id u40so1507521ugc.29 for ; Fri, 21 Mar 2008 08:28:54 -0700 (PDT) Received: by 10.66.248.5 with SMTP id v5mr2359644ugh.17.1206113334001; Fri, 21 Mar 2008 08:28:54 -0700 (PDT) Received: from ?192.168.0.116? ( [86.138.199.53]) by mx.google.com with ESMTPS id 39sm7499229ugb.15.2008.03.21.08.28.50 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 21 Mar 2008 08:28:52 -0700 (PDT) Cc: Stephen Bach , internals@lists.php.net Message-ID: <3A27DFE4-DA24-4A14-8E65-8177F5A366AE@googlemail.com> To: Antony Dovgal In-Reply-To: <47E3A581.9040107@daylessday.org> Content-Type: multipart/mixed; boundary=Apple-Mail-1-172859834 Mime-Version: 1.0 (Apple Message framework v919.2) Date: Fri, 21 Mar 2008 15:28:46 +0000 References: <200803172351.12440.stephen@stephenbach.net> <47E3A581.9040107@daylessday.org> X-Mailer: Apple Mail (2.919.2) Subject: Re: [PHP-DEV] [PATCH] Bug 43477 - Unicode error mode ignored From: foolistbar@googlemail.com (Geoffrey Sneddon) --Apple-Mail-1-172859834 Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit On 21 Mar 2008, at 12:09, Antony Dovgal wrote: > On 03/18/2008 06:51 AM, Stephen Bach wrote: >> Attached is a simple proposed patch that fixes Bug 43477. >> Basically, the code >> that set the error mode of the ICU converter was giving it an >> instruction >> (the context parameter) to only skip or substitute if the code >> point was not >> represented in the new encoding. However, it still was returning an >> error for >> illegal sequences. >> >> The test suite returns the same results with or without the patch. >> Test also >> attached. > > Patch committed, thanks. Can we test U_CONV_ERROR_SUBST too? See attached patch. Also, the bug should be closed. -- Geoffrey Sneddon --Apple-Mail-1-172859834 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit --Apple-Mail-1-172859834--