Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:36232 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 83674 invoked from network); 21 Mar 2008 12:09:43 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 21 Mar 2008 12:09:43 -0000 Authentication-Results: pb1.pair.com header.from=tony@daylessday.org; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=tony@daylessday.org; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain daylessday.org designates 89.208.40.236 as permitted sender) X-PHP-List-Original-Sender: tony@daylessday.org X-Host-Fingerprint: 89.208.40.236 mail.daylessday.org Linux 2.6 Received: from [89.208.40.236] ([89.208.40.236:41485] helo=daylessday.org) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id B8/66-42510-585A3E74 for ; Fri, 21 Mar 2008 07:09:42 -0500 Received: from [192.168.3.91] (unknown [212.42.62.198]) by daylessday.org (Postfix) with ESMTP id EB2116400ED; Fri, 21 Mar 2008 15:09:37 +0300 (MSK) Message-ID: <47E3A581.9040107@daylessday.org> Date: Fri, 21 Mar 2008 15:09:37 +0300 User-Agent: Thunderbird 2.0.0.9 (X11/20071114) MIME-Version: 1.0 To: Stephen Bach CC: internals@lists.php.net References: <200803172351.12440.stephen@stephenbach.net> In-Reply-To: <200803172351.12440.stephen@stephenbach.net> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [PHP-DEV] [PATCH] Bug 43477 - Unicode error mode ignored From: tony@daylessday.org (Antony Dovgal) On 03/18/2008 06:51 AM, Stephen Bach wrote: > Attached is a simple proposed patch that fixes Bug 43477. Basically, the code > that set the error mode of the ICU converter was giving it an instruction > (the context parameter) to only skip or substitute if the code point was not > represented in the new encoding. However, it still was returning an error for > illegal sequences. > > The test suite returns the same results with or without the patch. Test also > attached. Patch committed, thanks. -- Wbr, Antony Dovgal