Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:36202
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 64.233.170.189 as permitted sender)
DomainKey-Status: bad
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=beta;
        h=message-id:date:from:sender:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references:x-google-sender-auth;
        b=umdeMYbmIuTuWdMRBa0xoV3tYyX8tBiBN5r8ukdJIcCNaBBhf+lTDFcA5Qff2bicz0V0VEDcMtcVvzIg1Js20QfaX/7AEqfDDj/VAFt03kLUF0N4l5ahRlpfCLxH+1Nw0hmQzYG9bYuLVTk6O/MkZB5ZYp4LZD1rLPlqCIDayEs=
Message-ID: <e666c3890803181604s26451595r1c6d7f7d8037e85f@mail.gmail.com>
Date: Wed, 19 Mar 2008 00:04:11 +0100
Sender: ekneuss@gmail.com
To: "Mike Lively" <m@digitalsandwich.com>
Cc: "PHP Internals List" <internals@lists.php.net>
In-Reply-To: <8d7b8c130803181155i78702123o8ab91e047bf54132@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <8d7b8c130803122114i1062a961t99c49c06867803e3@mail.gmail.com>
	 <8d7b8c130803130648w112c4184l35482341bfeb7a9e@mail.gmail.com>
	 <8d7b8c130803181155i78702123o8ab91e047bf54132@mail.gmail.com>
Subject: Re: [PHP-DEV] Re: [PATCH] LSB - new patches for forward_static_call and parent:: forwarding (was: 5.3 Release Planning)
From: colder@php.net ("Etienne Kneuss")

Hello,

the forward_static_call looks like a decent non-intrusive solution,
and your patch looks
good from what I can tell! I guess you should commit it so it can be
documented and all.

regards

On Tue, Mar 18, 2008 at 7:55 PM, Mike Lively <m@digitalsandwich.com> wrote:
> On Thu, Mar 13, 2008 at 6:48 AM, Mike Lively <m@digitalsandwich.com> wrote:
>
>  >
>  > New patches can be found at
>  > http://www.digitalsandwich.com/Patches/index.html
>  >
>  > I have fixed the forward_static_call (I am not attached to the name and am
>  > open to suggestions) patch to use a callable. In doing this I also added an
>  > additional check to make sure the called_class is only forwarded if the
>  > class whose method being called is an ancestor of the current class. If that
>  > is not the case, then the behaviour will actually be identical to
>  > call_user_func*.
>  >
>  > I created against patch for both 5_3 and 6.
>  >
>  > I have also updated and attached that parent:: forwarding patch for both
>  > 5_3 and 6. In the event that someone wants to look at that (PLEASE??? ;)).
>  >
>  > - Mike Lively
>  >
>
>  Has anyone had a chance to look at this? I don't want to forget about it
>  again or before I know it 5.3 RCs will be out and I will have missed the
>  boat...again...
>



-- 
Etienne Kneuss
http://www.colder.ch

Men never do evil so completely and cheerfully as
when they do it from a religious conviction.
-- Pascal