Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:36198
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain stephenbach.net from 208.113.200.5 cause and error)
To: Andrei Zmievski <andrei@gravitonic.com>
Date: Tue, 18 Mar 2008 15:37:16 -0400
User-Agent: KMail/1.9.6
References: <200803172351.12440.stephen@stephenbach.net> <47DFFF31.607@gravitonic.com>
In-Reply-To: <47DFFF31.607@gravitonic.com>
Cc: internals@lists.php.net
MIME-Version: 1.0
Content-Type: text/plain;
  charset="utf-8"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-ID: <200803181537.16247.stephen@stephenbach.net>
Subject: Re: [PHP-DEV] [PATCH] Bug 43477 - Unicode error mode ignored
From: stephen@stephenbach.net (Stephen Bach)

I'm just suggesting that other error modes should do what they claim to do. 
Stopping on an illegal sequence is fine, unless the user had called a 
function telling the converter to do something else.

U_CONV_ERROR_STOP: stops on illegal character (the default)
U_CONV_ERROR_ESCAPE_*: 5 different modes that escape the illegal sequence in 
various ways

Shouldn't U_CONV_ERROR_SKIP and U_CONV_ERROR_SUBST work the same way?

-Stephen

On Tuesday 18 March 2008 01:43:13 pm Andrei wrote:
> Why would we not want to stop on illegal sequences?
>
> -Andrei
>
> Stephen Bach wrote:
> > Attached is a simple proposed patch that fixes Bug 43477. Basically, the
> > code that set the error mode of the ICU converter was giving it an
> > instruction (the context parameter) to only skip or substitute if the
> > code point was not represented in the new encoding. However, it still was
> > returning an error for illegal sequences.
> >
> > The test suite returns the same results with or without the patch. Test
> > also attached.
> >
> > -Stephen Bach