Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:36195
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain lerdorf.com from 204.11.219.139 cause and error)
Message-ID: <47E008E9.9080509@lerdorf.com>
Date: Tue, 18 Mar 2008 11:24:41 -0700
User-Agent: Thunderbird 2.0.0.4 (Macintosh/20070604)
MIME-Version: 1.0
To: Stanislav Malyshev <stas@zend.com>
CC:  internals@lists.php.net
References: <47DF3CC2.6040207@lerdorf.com> <47E00673.3020200@zend.com>
In-Reply-To: <47E00673.3020200@zend.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] setjmp usage
From: rasmus@lerdorf.com (Rasmus Lerdorf)

Stanislav Malyshev wrote:
> Hi!
> 
>> We are using setjmp(__bailout) in zend_try, but setjmp behaves 
>> differently on BSD and Linux.  POSIX doesn't specify whether the 
>> signal mask should be saved or not for this call, so different 
>> operating systems do different things here.  I think it would be more 
>> consistent if we used sigsetjmp(__bailout,0) to always specify that we 
>> don't need to store the signal mask.  This avoids an expensive 
>> sigprocmask syscall.
> 
> Sounds good. Can we still use longjmp or have to use siglongjmp?

It's the same thing for longjmp.  POSIX doesn't specify what should be 
done with the signal mask after a longjmp either, so to be consistent we 
should use siglongjmp() as well and explicitly define what we want to do 
with the signal mask.

I'll work up a patch.

-Rasmus