Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:36193
Return-Path: <andrei@gravitonic.com>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 45863 invoked from network); 18 Mar 2008 17:43:21 -0000
Received: from unknown (HELO lists.php.net) (127.0.0.1)
  by localhost with SMTP; 18 Mar 2008 17:43:21 -0000
Authentication-Results: pb1.pair.com smtp.mail=andrei@gravitonic.com; spf=permerror; sender-id=unknown
Authentication-Results: pb1.pair.com header.from=andrei@gravitonic.com; sender-id=unknown
Received-SPF: error (pb1.pair.com: domain gravitonic.com from 209.85.132.242 cause and error)
X-PHP-List-Original-Sender: andrei@gravitonic.com
X-Host-Fingerprint: 209.85.132.242 an-out-0708.google.com  
Received: from [209.85.132.242] ([209.85.132.242:62124] helo=an-out-0708.google.com)
	by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP
	id D4/87-06623-83FFFD74 for <internals@lists.php.net>; Tue, 18 Mar 2008 12:43:21 -0500
Received: by an-out-0708.google.com with SMTP id d26so5884and.59
        for <internals@lists.php.net>; Tue, 18 Mar 2008 10:43:17 -0700 (PDT)
Received: by 10.100.41.8 with SMTP id o8mr2254723ano.82.1205862197709;
        Tue, 18 Mar 2008 10:43:17 -0700 (PDT)
Received: from Macintosh-5.local ( [206.15.64.202])
        by mx.google.com with ESMTPS id s30sm4276442elf.17.2008.03.18.10.43.16
        (version=TLSv1/SSLv3 cipher=RC4-MD5);
        Tue, 18 Mar 2008 10:43:16 -0700 (PDT)
Message-ID: <47DFFF31.607@gravitonic.com>
Date: Tue, 18 Mar 2008 10:43:13 -0700
User-Agent: Thunderbird 2.0.0.6 (Macintosh/20070807)
MIME-Version: 1.0
To: Stephen Bach <stephen@stephenbach.net>
CC:  internals@lists.php.net
References: <200803172351.12440.stephen@stephenbach.net>
In-Reply-To: <200803172351.12440.stephen@stephenbach.net>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] [PATCH] Bug 43477 - Unicode error mode ignored
From: andrei@gravitonic.com (Andrei Zmievski)

Why would we not want to stop on illegal sequences?

-Andrei

Stephen Bach wrote:
> Attached is a simple proposed patch that fixes Bug 43477. Basically, the code 
> that set the error mode of the ICU converter was giving it an instruction 
> (the context parameter) to only skip or substitute if the code point was not 
> represented in the new encoding. However, it still was returning an error for 
> illegal sequences.
> 
> The test suite returns the same results with or without the patch. Test also 
> attached.
> 
> -Stephen Bach
>