Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:36104
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain zend.com designates 212.25.124.162 as permitted sender)
Content-class: urn:content-classes:message
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Date: Wed, 12 Mar 2008 10:54:21 +0200
Message-ID: <06B0D32C7A96544490D18AF653D6BDE5026B9D33@il-ex1.zend.net>
Thread-Topic: [ZEND-ENGINE-CVS] cvs: ZendEngine2(PHP_5_3) / zend_API.c zend_builtin_functions.c zend_compile.h zend_execute.c zend_execute.h zend_execute_API.c zend_globals.h zend_vm_def.h zend_vm_execute.h zend_vm_execute.skl zend_vm_gen.php  /tests
Thread-Index: AciCy6+UzcQCgGxrRLSufblG0vnsXQBUt2Sw
To: "Steph Fox" <steph@zend.com>
Cc: "internals" <internals@lists.php.net>
Subject: RE: [ZEND-ENGINE-CVS] cvs: ZendEngine2(PHP_5_3) / zend_API.c zend_builtin_functions.c zend_compile.h zend_execute.c zend_execute.h zend_execute_API.c zend_globals.h zend_vm_def.h zend_vm_execute.h zend_vm_execute.skl zend_vm_gen.php  /tests
From: dmitry@zend.com ("Dmitry Stogov")

Sorry for dealy.
It must be fixed now.

Thanks. Dmitry.

> -----Original Message-----
> From: Steph Fox [mailto:steph@zend.com]=20
> Sent: Monday, March 10, 2008 7:26 PM
> To: Dmitry Stogov
> Cc: internals
> Subject: Re: [ZEND-ENGINE-CVS] cvs: ZendEngine2(PHP_5_3) /=20
> zend_API.c zend_builtin_functions.c zend_compile.h=20
> zend_execute.c zend_execute.h zend_execute_API.c=20
> zend_globals.h zend_vm_def.h zend_vm_execute.h=20
> zend_vm_execute.skl zend_vm_gen.php /tests
>=20
>=20
> Hi Dmitry,
>=20
> I finally got around to upgrading my compiler over the=20
> weekend, but I still=20
> have to fiddle with line 229 of zend_execute.h to get sane=20
> nmake output in=20
> the 5_3 branch. And I'm not alone - see=20
> http://snaps.php.net/win32/snapshot-5.3.log, now it's back=20
> up. The only=20
> place it doesn't throw a warning is in the debug build.
>=20
> Can you please fix it?
>=20
> Thanks,
>=20
> - Steph
>=20
> ps Sorry for top-posting, the alternative didn't bear thinking about.
>=20
> > Oh. I meant MSVC6-SP5.
> > Could you please verify the version with "cl" command.
> >
> > Dmitry.
> >
> > Steph Fox wrote:
> >> But not MSVC6?
> >>
> >> Why would I get a compiler warning and you not? That=20
> doesn't make a=20
> >> lot
> >> of sense.
> >>
> >> ----- Original Message ----- From: "Dmitry Stogov"=20
> <dmitry@zend.com>
> >> To: "Steph Fox" <steph@zend.com>
> >> Cc: "Dmitry Stogov" <dmitry@php.net>;=20
> <zend-engine-cvs@lists.php.net>
> >> Sent: Thursday, January 24, 2008 4:18 PM
> >> Subject: Re: [ZEND-ENGINE-CVS] cvs: ZendEngine2(PHP_5_3) /=20
> zend_API.c
> >> zend_builtin_functions.c zend_compile.h zend_execute.c=20
> zend_execute.h=20
> >> zend_execute_API.c zend_globals.h zend_vm_def.h zend_vm_execute.h=20
> >> zend_vm_execute.skl zend_vm_gen.php /tests
> >>
> >>
> >>> I tried MSVC5 too. no warnings.
> >>>
> >>> > cl
> >>>
> >>> Microsoft (R) 32-bit C/C++ Optimizing Compiler Version 12.00.8804=20
> >>> for
> >>> 80x86
> >>> Copyright (C) Microsoft Corp 1984-1998. All rights reserved.
> >>>
> >>> Dmitry.
> >>>
> >>> Steph Fox wrote:
> >>>> MSVC6 - which is still used for official php.net builds + snaps=20
> >>>> because
> >>>> everything Apache not CGI/CLI fails otherwise.
> >>>>
> >>>> Configure line is: --with-bz2 --enable-phar=20
> --enable-zip=3Dshared. I
> >>>> don't recommend trying that @ present (phar build's=20
> broken for me) but=20
> >>>> I think you'll agree it doesn't affect ZE warnings.
> >>>>
> >>>> - Steph
> >>>>
> >>>>
> >>>>> Hi Steph,
> >>>>>
> >>>>> What compiler/configure option do you use?
> >>>>> I don't have such warnings.
> >>>>>
> >>>>> Thanks. Dmitry.
> >>>>>
> >>>>> Steph Fox wrote:
> >>>>>> Hi Dmitry,
> >>>>>>
> >>>>>> This change led to an interesting make output here. The whole=20
> >>>>>> thing
> >>>>>> looks like this throughout:
> >>>>>>
> >>>>>> Zend\zend_execute.h(229) : warning C4018: '>' : signed/unsigned
> >>>>>> mismatch
> >>>>>> sanitizing_filters.c
> >>>>>> Zend\zend_execute.h(229) : warning C4018: '>' :=20
> signed/unsigned=20
> >>>>>> mismatch
> >>>>>> ftp.c
> >>>>>> Zend\zend_execute.h(229) : warning C4018: '>' :=20
> signed/unsigned=20
> >>>>>> mismatch
> >>>>>> php_ftp.c
> >>>>>> Zend\zend_execute.h(229) : warning C4018: '>' :=20
> signed/unsigned=20
> >>>>>> mismatch
> >>>>>> hash.c
> >>>>>> Zend\zend_execute.h(229) : warning C4018: '>' :=20
> signed/unsigned=20
> >>>>>> mismatch
> >>>>>> hash_adler32.c
> >>>>>> Zend\zend_execute.h(229) : warning C4018: '>' :=20
> signed/unsigned=20
> >>>>>> mismatch
> >>>>>> hash_crc32.c
> >>>>>> Zend\zend_execute.h(229) : warning C4018: '>' :=20
> signed/unsigned=20
> >>>>>> mismatch
> >>>>>> hash_gost.c
> >>>>>> Zend\zend_execute.h(229) : warning C4018: '>' :=20
> signed/unsigned=20
> >>>>>> mismatch
> >>>>>>
> >>>>>> I wasn't aware of zend_execute.h being called so many=20
> times until
> >>>>>> now, but maybe that's just because there's a warning=20
> now that wasn't=20
> >>>>>> there before? I can kill the warning easily enough:
> >>>>>>
> >>>>>> ZEND_VM_STACK_GROW_IF_NEEDED((int)size);
> >>>>>>
> >>>>>> but I've no idea if that breaks anything delicate.
> >>>>>>
> >>>>>> - Steph
> >>>>>>
> >>>>>>
> >>>>>> ----- Original Message ----- From: "Dmitry Stogov"=20
> >>>>>> <dmitry@php.net>
> >>>>>> To: <zend-engine-cvs@lists.php.net>
> >>>>>> Sent: Thursday, January 24, 2008 9:41 AM
> >>>>>> Subject: [ZEND-ENGINE-CVS] cvs: ZendEngine2(PHP_5_3) /=20
> zend_API.c=20
> >>>>>> zend_builtin_functions.c zend_compile.h zend_execute.c=20
> zend_execute.h=20
> >>>>>> zend_execute_API.c zend_globals.h zend_vm_def.h=20
> zend_vm_execute.h=20
> >>>>>> zend_vm_execute.skl zend_vm_gen.php /tests=20
> bug41209.phpt php-src NEWS
> >>>>>>
> >>>>>>
> >>>>>>> dmitry Thu Jan 24 09:41:41 2008 UTC
> >>>>>>>
> >>>>>>>  Modified files:              (Branch: PHP_5_3)
> >>>>>>>    /php-src NEWS
> >>>>>>>    /ZendEngine2 zend_API.c zend_builtin_functions.c=20
> zend_compile.h
> >>>>>>>                zend_execute.c zend_execute.h=20
> zend_execute_API.c
> >>>>>>>                zend_globals.h zend_vm_def.h zend_vm_execute.h
> >>>>>>>                zend_vm_execute.skl zend_vm_gen.php
> >>>>>>>    /ZendEngine2/tests bug41209.phpt
> >>>>>>>  Log:
> >>>>>>>  Changed EG(argument_stack) implementation.
> >>>>>>>
> >>>>>>>
> >>>>>>
> >>>>>>
> >>>>>>=20
> -----------------------------------------------------------------
> >>>>>> ---------------
> >>>>>>
> >>>>>>
> >>>>>>
> >>>>>>
> >>>>>>
> >>>>>>> --
> >>>>>>> Zend Engine CVS Mailing List (http://cvs.php.net/)
> >>>>>>> To unsubscribe, visit: http://www.php.net/unsub.php
> >>>>>>
> >>>>
> >>=20
>=20