Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:36049 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 42862 invoked from network); 7 Mar 2008 16:02:21 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 7 Mar 2008 16:02:21 -0000 Authentication-Results: pb1.pair.com header.from=jani.taskinen@sci.fi; sender-id=unknown Authentication-Results: pb1.pair.com smtp.mail=jani.taskinen@sci.fi; spf=permerror; sender-id=unknown Received-SPF: error (pb1.pair.com: domain sci.fi from 63.208.196.179 cause and error) X-PHP-List-Original-Sender: jani.taskinen@sci.fi X-Host-Fingerprint: 63.208.196.179 mho-02-bos.mailhop.org Received: from [63.208.196.179] ([63.208.196.179:52611] helo=mho-02-bos.mailhop.org) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 42/CC-19009-C0761D74 for ; Fri, 07 Mar 2008 11:02:20 -0500 Received: from [81.22.163.71] (helo=[10.6.109.198]) by mho-02-bos.mailhop.org with esmtpsa (SSLv3:RC4-MD5:128) (Exim 4.68) (envelope-from ) id 1JXf1V-000N8m-4z; Fri, 07 Mar 2008 16:02:17 +0000 X-Mail-Handler: MailHop Outbound by DynDNS X-Originating-IP: 81.22.163.71 X-Report-Abuse-To: abuse@dyndns.com (see http://www.mailhop.org/outbound/abuse.html for abuse reporting information) X-MHO-User: U2FsdGVkX19fU0+1eOxivWJAmTUNGqxz7sI9etSllqw= Reply-To: jani.taskinen@iki.fi To: Felipe Pena Cc: internals@lists.php.net In-Reply-To: <46ccd1ab0803070743h53a74282sdf718b7fbde158f@mail.gmail.com> References: <1204594018.5832.29.camel@pena> <46ccd1ab0803070743h53a74282sdf718b7fbde158f@mail.gmail.com> Content-Type: text/plain Date: Fri, 07 Mar 2008 18:02:14 +0200 Message-ID: <1204905734.14899.2.camel@localhost.localdomain> Mime-Version: 1.0 X-Mailer: Evolution 2.8.3 (2.8.3-2.fc6) Content-Transfer-Encoding: 7bit Subject: Re: [PHP-DEV] Re: Fix for #39018 (suppressing error messages) From: jani.taskinen@sci.fi (Jani Taskinen) It means "You didn't commit, nobody cares." Read: Just commit..that'll wake them up. ;) --Jani On Fri, 2008-03-07 at 12:43 -0300, Felipe Pena wrote: > Hello, > > no reply means "no! don't touch." ? > > > Thanks. > > 2008/3/3, Felipe Pena : > > Hello developers, > > > > I made a patch for the bug#39018: > > > > $x = 'test'; > > @$x[4] == 'a'; > > (@$x[4]) == 'a'; > > (@($x[4])) == 'a'; > > @($x[4]) == 'a'; > > $foo = 'test'; $x = @$foo[6]; > > > > Actually, all cases above shows E_NOTICE. > > With the patch, E_NOTICE is not showed. > > > > Patches: > > [5.3] http://felipe.ath.cx/diff/bug39018.diff > > [HEAD] http://felipe.ath.cx/diff/bug39018-HEAD.diff > > > > > > > > However, this patch breaks one test in Zend/tests/, because of an > > E_NOTICE: > > > > --TEST-- > > Bug #39304 (Segmentation fault with list unpacking of string offset) > > --FILE-- > > > $s = ""; > > list($a, $b) = $s[0]; > > ?> > > --EXPECTF-- > > Fatal error: Cannot use string offset as an array in %sbug39304.php on > > line 3 > > > > Diff: > > 001+ Notice: Uninitialized string offset: 0 ... > > > > > > > > Would be this a problem? Looks right to me... > > > > Finally, any objection? > > > > > > Tests for the this fix: > > - http://felipe.ath.cx/diff/bug39018.phpt > > - http://felipe.ath.cx/diff/bug39018_2.phpt > > > > > > > > Thanks. > > > > -- > > Regards, > > > > Felipe Pena. > > > > > -- Patches/Donations: http://pecl.php.net/~jani/