Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:36048 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 36279 invoked from network); 7 Mar 2008 15:43:31 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 7 Mar 2008 15:43:31 -0000 Authentication-Results: pb1.pair.com header.from=felipensp@gmail.com; sender-id=pass; domainkeys=bad Authentication-Results: pb1.pair.com smtp.mail=felipensp@gmail.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 64.233.166.183 as permitted sender) DomainKey-Status: bad X-DomainKeys: Ecelerity dk_validate implementing draft-delany-domainkeys-base-01 X-PHP-List-Original-Sender: felipensp@gmail.com X-Host-Fingerprint: 64.233.166.183 py-out-1112.google.com Received: from [64.233.166.183] ([64.233.166.183:48557] helo=py-out-1112.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id A8/4B-19009-1A261D74 for ; Fri, 07 Mar 2008 10:43:30 -0500 Received: by py-out-1112.google.com with SMTP id u77so704124pyb.16 for ; Fri, 07 Mar 2008 07:43:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; bh=8UQrE5nfQUfG+YrnCGwZEu85d1Q0nLKWljXzgClUZ4Q=; b=Sr1xpnmGm9FszTGOdVXUXNq4nUvWo00q3tY6ayheHKsIL7emd4WTcMBSg5H8GXtlgVgYFidsac7KRV66uBYEmQz3PY1z8WedCqZenhDIaIOSynYN8PfH8+8GZbjV1ApWs7HaFyT+ErjeWGUU4rrrCIn9zIJsvgEJD9Amruoon9U= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=MI2GQzRht8sJkwAPmeePQKBfauDHmmC1zfsB1gdtg6m+yCOEVUk3zBriElvQYl9T78UNiplIqbM6rY1KF6t6KmKgSBlC4rI7wpp66Fw64+Rpp2CWDIuWdBu5vPq9Ch1Dn5lwuw2f3R8VwkH3ZFh9d/pQn1MzyDQ5TiTrM1Bd4PQ= Received: by 10.35.51.19 with SMTP id d19mr1187633pyk.11.1204904607091; Fri, 07 Mar 2008 07:43:27 -0800 (PST) Received: by 10.35.93.13 with HTTP; Fri, 7 Mar 2008 07:43:27 -0800 (PST) Message-ID: <46ccd1ab0803070743h53a74282sdf718b7fbde158f@mail.gmail.com> Date: Fri, 7 Mar 2008 12:43:27 -0300 To: internals@lists.php.net In-Reply-To: <1204594018.5832.29.camel@pena> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <1204594018.5832.29.camel@pena> Subject: Re: Fix for #39018 (suppressing error messages) From: felipensp@gmail.com ("Felipe Pena") Hello, no reply means "no! don't touch." ? Thanks. 2008/3/3, Felipe Pena : > Hello developers, > > I made a patch for the bug#39018: > > $x = 'test'; > @$x[4] == 'a'; > (@$x[4]) == 'a'; > (@($x[4])) == 'a'; > @($x[4]) == 'a'; > $foo = 'test'; $x = @$foo[6]; > > Actually, all cases above shows E_NOTICE. > With the patch, E_NOTICE is not showed. > > Patches: > [5.3] http://felipe.ath.cx/diff/bug39018.diff > [HEAD] http://felipe.ath.cx/diff/bug39018-HEAD.diff > > > > However, this patch breaks one test in Zend/tests/, because of an > E_NOTICE: > > --TEST-- > Bug #39304 (Segmentation fault with list unpacking of string offset) > --FILE-- > $s = ""; > list($a, $b) = $s[0]; > ?> > --EXPECTF-- > Fatal error: Cannot use string offset as an array in %sbug39304.php on > line 3 > > Diff: > 001+ Notice: Uninitialized string offset: 0 ... > > > > Would be this a problem? Looks right to me... > > Finally, any objection? > > > Tests for the this fix: > - http://felipe.ath.cx/diff/bug39018.phpt > - http://felipe.ath.cx/diff/bug39018_2.phpt > > > > Thanks. > > -- > Regards, > > Felipe Pena. > >