Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:35807
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.132.250 as permitted sender)
DomainKey-Status: bad
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=message-id:date:from:reply-to:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references;
        b=Q0aoJ/T46jtS8AyferNGFNyC3BCTcW/nJvkMtTdJY/1E2Y6l32f30pLMqyTeERln/0MvKMVrpzE6Q41iHfAgpjFr5JEd1YvWFwXnYlC5Efj9L8seiho38IuzmpR4f5WB5QbI+D/EJRt1O5pe1apXxCPqVU5fVzQ7Fp6KOaveBxg=
Message-ID: <5a8807d10802260934n4da71d07v73e9b60fd1d48326@mail.gmail.com>
Date: Tue, 26 Feb 2008 17:34:49 +0000
Reply-To: robin@soal.org
To: "Marcus Boerger" <helly@php.net>, internals@lists.php.net
Cc: "Jochem Maas" <jochem@iamjochem.com>
In-Reply-To: <5a8807d10801280937j11c65623l7dca63aebec7cf1a@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <5a8807d10801280520u7f8c7a9o8d2ab2efaa9c7644@mail.gmail.com>
	 <1109819085.20080128151237@marcus-boerger.de>
	 <5a8807d10801280718p6d52f689s3a13c4d8c6521a3f@mail.gmail.com>
	 <868592137.20080128174926@marcus-boerger.de>
	 <5a8807d10801280937j11c65623l7dca63aebec7cf1a@mail.gmail.com>
Subject: Re: [PHP-DEV] Protected static props redeclared as public share value across classes
From: rewbs.soal@gmail.com ("Robin Fernandes")

Hi Marcus,

On 28/01/2008, Marcus Boerger <helly@php.net> wrote:
>  >
>  >   I checked it out in more detail and it is indeed broken as in it is not
>  > consistent

If possible, I'd like to revive this discussion. Patch included. :)
History: http://thread.gmane.org/gmane.comp.php.devel/47956/focus=47956

To summarize, we agree that there is an inconsistency related to
static property inheritance, because:

--> In the following case, A::$p and B::$p share the same value:
class A { protected static $p; } class B extends A { public static $p; }

--> Yet in the following cases, A::$p and B::$p have two separate values:
class A { protected static $p; } class B extends A { protected static $p; }
class A { public static $p; } class B extends A { public static $p; }

You originally suggested fixing the inconsistency by changing the last
2 cases, so that A::$p and B::$p always share the same value. However,
that approach raised some concerns described by myself and Jochem, for
example:
--> Inconsistency with overridden methods
--> Inconsistency with shadowed class constants.

Consequently, I'd like to propose resolving this by changing the first
case, so that A::$p and B::$p always have separate values.

Here's a patch that implements this. It includes relevant changes to
existing tests, plus some supplementary tests to address Jochem's
concern about the impact on LSB.

Patch against snap php6.0-200802251530: http://pastebin.ca/919094
Disclaimer: I am not an internals expert - patch might overlook some
cases, feedback welcome. :)

Let me know what you think.

Regards,
Robin