Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:35771 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 11180 invoked by uid 1010); 24 Feb 2008 18:36:19 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 11165 invoked from network); 24 Feb 2008 18:36:19 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 24 Feb 2008 18:36:19 -0000 Authentication-Results: pb1.pair.com smtp.mail=felipensp@gmail.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=felipensp@gmail.com; sender-id=pass; domainkeys=bad Received-SPF: pass (pb1.pair.com: domain gmail.com designates 66.249.82.228 as permitted sender) DomainKey-Status: bad X-DomainKeys: Ecelerity dk_validate implementing draft-delany-domainkeys-base-01 X-PHP-List-Original-Sender: felipensp@gmail.com X-Host-Fingerprint: 66.249.82.228 wx-out-0506.google.com Received: from [66.249.82.228] ([66.249.82.228:35413] helo=wx-out-0506.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id B5/C0-00312-229B1C74 for ; Sun, 24 Feb 2008 13:36:19 -0500 Received: by wx-out-0506.google.com with SMTP id s14so1436130wxc.26 for ; Sun, 24 Feb 2008 10:36:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:subject:from:to:cc:in-reply-to:references:content-type:date:message-id:mime-version:x-mailer:content-transfer-encoding; bh=Euu8tASWKjkFli5fk18Uamp9eYmWI6Ad2ZBbYysmDiM=; b=twQpCCw46eu2FfLKBYSGzEqgDngG8N6sY9zpk3JexqUV0xGm/VBgAbwjkkkxKpb/iqw2QrtolZnFCFRfAqaEac2WCFMuwnhYKW5Ml6AqZkZVX/2tqTPhlENz0hHHgkxUu/S8bQRC0ngiiO/g6futjwAdOT7F/mAC+qXiHw6Wz3M= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=subject:from:to:cc:in-reply-to:references:content-type:date:message-id:mime-version:x-mailer:content-transfer-encoding; b=TN3gQHy6ayHkVmbHO3D5L+yFTZuIy3XhR9CyhIkpZQRmSfCSOIdjRgEJZPz4er0WXhRTsAQGPdH1ucwNkOd5Wzp/XRUXLoXzIaZV2Lksmci5ZK+w4sdcFdez+sygrsS8dWrmZMNxqFH6DFTGaWZDLeOOwXQLTDgkn4DVZtyebWU= Received: by 10.100.31.3 with SMTP id e3mr352734ane.1.1203878176935; Sun, 24 Feb 2008 10:36:16 -0800 (PST) Received: from ?192.168.1.2? ( [189.24.11.196]) by mx.google.com with ESMTPS id e27sm4898466elf.9.2008.02.24.10.36.15 (version=TLSv1/SSLv3 cipher=RC4-MD5); Sun, 24 Feb 2008 10:36:16 -0800 (PST) To: Arnar Mar Sig Cc: internals@lists.php.net In-Reply-To: References: <3BA7F322-7E34-4F8D-BD2B-6F59DA3139FB@valka.is> Content-Type: text/plain; charset=utf-8 Date: Sun, 24 Feb 2008 15:36:06 -0300 Message-ID: <1203878166.5914.1.camel@pena> Mime-Version: 1.0 X-Mailer: Evolution 2.10.1 Content-Transfer-Encoding: 8bit Subject: Re: [PHP-DEV] [PATCH] Fix segfault in filter extension when using callbacks From: felipensp@gmail.com (Felipe Pena) Em Dom, 2008-02-24 às 15:48 +0000, Arnar Mar Sig escreveu: > Erm, the attachement got stripped away, heres the patch.. > > --- php-5.2.5/ext/filter/filter.c 2007-04-04 20:50:26.000000000 +0000 > +++ php-5.2.5-fixed/ext/filter/filter.c 2008-02-24 15:14:19.000000000 > +0000 > @@ -322,7 +322,7 @@ > filter_func.function(*value, flags, options, charset TSRMLS_CC); > > if ( > - options && > + options && (Z_TYPE_P(options) == IS_ARRAY || Z_TYPE_P(options) > == IS_OBJECT) && > ((flags & FILTER_NULL_ON_FAILURE && Z_TYPE_PP(value) == > IS_NULL) || > (!(flags & FILTER_NULL_ON_FAILURE) && Z_TYPE_PP(value) == > IS_BOOL && Z_LVAL_PP(value) == 0)) && > zend_hash_exists(HASH_OF(options), "default", > sizeof("default")) > > Arnar Mar Sig Fixed in CVS. Thanks. -- Regards, Felipe Pena.