Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:35768
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain valka.is from 213.176.128.13 cause and error)
Message-ID: <3BA7F322-7E34-4F8D-BD2B-6F59DA3139FB@valka.is>
To: internals@lists.php.net
Content-Type: multipart/mixed; boundary=Apple-Mail-14-74465885
Mime-Version: 1.0 (Apple Message framework v919.2)
Date: Sun, 24 Feb 2008 15:37:28 +0000
Subject: [PATCH] Fix segfault in filter extension when using callbacks
From: antab@valka.is (Arnar Mar Sig)

--Apple-Mail-14-74465885
Content-Type: text/plain;
	charset=US-ASCII;
	format=flowed;
	delsp=yes
Content-Transfer-Encoding: 7bit

The filter extensinon will segfault if a callback filter returns  
FALSE, this little patch fixes that.

There is also no way to set default value if the callback fails  
because of a design flow. When dealing with callbacks the 'options'  
key in the options parameters just be a valid callback, but to set a  
default value then this key must be a array that includes the key  
'default'.


Test case:
function filter_test($str) { return FALSE; }
var_dump(filter_var('durty/boy', FILTER_CALLBACK, array(
   'options'   => 'filter_test',
)));


Arnar Mar Sig


--Apple-Mail-14-74465885
Content-Type: text/plain;
	charset=US-ASCII;
	format=flowed
Content-Transfer-Encoding: 7bit



--Apple-Mail-14-74465885--