Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:35637
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 64.233.166.178 as permitted sender)
DomainKey-Status: bad
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:references;
        b=KTHIe+MWNRpuYgnWGUEAnTR4qrcbz+LUJCDOPTHuiOJnxi+ag9lzn5tV67LSTbqknpv+FV5OUlg28ZT9VryLrM8j3yuvkipXO6ms674n/sm+ZlYl+MT9k3NyNG3l0R3KjOfNntMkuc6yKmiAM087gW0eX0JEYPne+to9T31EwZo=
Message-ID: <46ccd1ab0802191912k54d38d1lce937b08481de4f6@mail.gmail.com>
Date: Wed, 20 Feb 2008 00:12:32 -0300
To: "Cristian Rodriguez" <judas.iscariote@gmail.com>
Cc: php-dev <internals@lists.php.net>
In-Reply-To: <7d5a202f0802190633r35b1652bu39fd6eef2f031b2e@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/alternative; 
	boundary="----=_Part_15997_1894614.1203477152771"
References: <1203391281.6475.18.camel@pena>
	 <1465625877.20080219122858@marcus-boerger.de>
	 <1203421924.5314.8.camel@felipe>
	 <7d5a202f0802190633r35b1652bu39fd6eef2f031b2e@mail.gmail.com>
Subject: Re: [PHP-DEV] Error messages for wrong coding
From: felipensp@gmail.com ("Felipe Pena")

------=_Part_15997_1894614.1203477152771
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

2008/2/19, Cristian Rodriguez <judas.iscariote@gmail.com>:
>
> There is a similar case with unset() an offset of booleans and integers.
>
> <?php
> $foo = true:
> /* should throw a fatal error, like it does when trying to unset string
> offsets.
> actually $foo remains unchanged after unset() (!!)
> unset($foo[0]);
>
> Index: Zend/zend_vm_def.h
> ===================================================================
> RCS file: /repository/ZendEngine2/zend_vm_def.h,v
> retrieving revision 1.59.2.29.2.48.2.36
> diff -u -p -r1.59.2.29.2.48.2.36 zend_vm_def.h
> --- Zend/zend_vm_def.h  11 Feb 2008 15:46:10 -0000
> 1.59.2.29.2.48.2.36
> +++ Zend/zend_vm_def.h  19 Feb 2008 14:32:18 -0000
> @@ -3281,6 +3281,7 @@ ZEND_VM_HANDLER(75, ZEND_UNSET_DIM, VAR|
>                                 zend_error_noreturn(E_ERROR, "Cannot
> unset string offsets");
>                                 ZEND_VM_CONTINUE(); /* bailed out before
> */
>                         default:
> +                               zend_error_noreturn(E_ERROR, "Cannot
> unset %s offsets", zend_get_type_by_const(Z_TYPE_PP(container)));
>                                 FREE_OP2();
>                                 break;
>                 }

Added!
I have updated the patch, because the bool variables (used internally on
foreach, list(.., ..) = each(...), for example) are passed also to
zend_fetch_dimension_address_read(), what break the previous patch (default:
zend_error...) Then, i think that this could be handled in zend_vm_def.h,
checking for OP1_TYPE != IS_VAR when the type is boolean.
Well, i don't know how the Zend Engine works properly... So, If i said
anything wrong, let me know, please.
Finally, this was my suggestion.
http://felipe.ath.cx/diff/bug39915.diff
Thanks.

------=_Part_15997_1894614.1203477152771--