Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:35585
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: unknown (pb1.pair.com: domain php.net does not designate 85.214.94.56 as permitted sender)
Date: Tue, 19 Feb 2008 12:28:58 +0100
Reply-To: Marcus Boerger <helly@php.net>
Message-ID: <1465625877.20080219122858@marcus-boerger.de>
To: Felipe Pena <felipensp@gmail.com>
CC: internals@lists.php.net
In-Reply-To: <1203391281.6475.18.camel@pena>
References: <1203391281.6475.18.camel@pena>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] Error messages for wrong coding
From: helly@php.net (Marcus Boerger)

Hello Felipe,

Tuesday, February 19, 2008, 4:21:20 AM, you wrote:

> Hi.
> Looking on "Feature/Change Request", i have seen curious things, and i
> think that them should issue any error message. See above.

> ---

> Bug #39915 - Trying to access the index of an integer should throw a
> warning:

> Actual result:

> $a = 1234;
> $a[0]; // Not shows error


> Proposed:
>  - Shows error message (Fatal error, as happens with objects) for
> integer and float variables.
>    http://felipe.ath.cx/diff/bug39915.diff

This patch results in two error message for type long, one complaining about
long, one about double. You can use function zend_get_type_by_const() to
avoid this. Also make sure that we see the new style message for type bool
and anything else that is not handled right now (aka just use default case).

> ---

> Bug #42852 - Inconsistent message when creating default object from
> empty value:

> Actual result:

> $obj1->p = 1; // Shows 'Strict Standards ...'

> $obj2->p[] = 1; // Not shows

> $a = 1;
> $obj3->p = &$a; // Not shows


> Proposed:
>  - 'Strict Standards' for all cases.
>    http://felipe.ath.cx/diff/bug42852.diff

Looks good.

Best regards,
 Marcus