Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:35577 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 17554 invoked by uid 1010); 19 Feb 2008 04:25:34 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 17537 invoked from network); 19 Feb 2008 04:25:34 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 19 Feb 2008 04:25:34 -0000 Authentication-Results: pb1.pair.com smtp.mail=judas.iscariote@gmail.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=judas.iscariote@gmail.com; sender-id=pass; domainkeys=bad Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.134.190 as permitted sender) DomainKey-Status: bad X-DomainKeys: Ecelerity dk_validate implementing draft-delany-domainkeys-base-01 X-PHP-List-Original-Sender: judas.iscariote@gmail.com X-Host-Fingerprint: 209.85.134.190 mu-out-0910.google.com Received: from [209.85.134.190] ([209.85.134.190:54241] helo=mu-out-0910.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 1F/75-23568-D3A5AB74 for ; Mon, 18 Feb 2008 23:25:33 -0500 Received: by mu-out-0910.google.com with SMTP id w8so1506816mue.1 for ; Mon, 18 Feb 2008 20:25:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; bh=y9VjJxFJvNb2rAtH4CHsc0hPd7I+PCKzgFQJIpb+zLE=; b=bL0uMjA1zQ2em05cuwdKokIoJBWNfDLEHotbwUq7Zu2IfaH27b0OHBOyz3acLA/L5LB0YSpYcqi+mVbs7H0CmlyjrKKbahL2VsfHorMouUkXnmfn8/hyx+aZV6lFPLpksIWLcl7cJ7GvrX0BKzo1po6PEYPsQTI8rTndOiPWzlk= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=xIAwYy42mPgLkoyOgCebG2GmJpsOhXvDhsCD0krJZS57Eu4w0VdjNqevbgpF2J7w7qvk0Rp0VKN2dAo4JZ0tRadh2pyfg7M/GBp8Qq4n/L8VGQpoRmLuzH6g8RE/NIS1uoyJq82L46RVTqdeSaB5sAxlMMF0F5e9jOxlBwxy4iw= Received: by 10.64.3.9 with SMTP id 9mr7632574qbc.0.1203395128323; Mon, 18 Feb 2008 20:25:28 -0800 (PST) Received: by 10.64.96.3 with HTTP; Mon, 18 Feb 2008 20:25:28 -0800 (PST) Message-ID: <7d5a202f0802182025t1f71333ayd2e2d55cd649c774@mail.gmail.com> Date: Tue, 19 Feb 2008 01:25:28 -0300 To: php-dev In-Reply-To: <7d5a202f0802182005h79befbd6q700138bae17d27b3@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <1203391281.6475.18.camel@pena> <7d5a202f0802182005h79befbd6q700138bae17d27b3@mail.gmail.com> Subject: Re: [PHP-DEV] Error messages for wrong coding From: judas.iscariote@gmail.com ("Cristian Rodriguez") 2008/2/19, Cristian Rodriguez : > 2008/2/19, Felipe Pena : > > > > > Proposed: > > - Shows error message (Fatal error, as happens with objects) for > > integer and float variables. > > http://felipe.ath.cx/diff/bug39915.diff > > +1 , fatal error for consistency. you need to handle offset of booleans too.. Index: Zend/zend_execute.c =================================================================== RCS file: /repository/ZendEngine2/zend_execute.c,v retrieving revision 1.716.2.12.2.24.2.20 diff -u -p -r1.716.2.12.2.24.2.20 zend_execute.c --- Zend/zend_execute.c 18 Feb 2008 12:11:47 -0000 1.716.2.12.2.24.2.20 +++ Zend/zend_execute.c 19 Feb 2008 04:22:41 -0000 @@ -1229,6 +1229,15 @@ static void zend_fetch_dimension_address } return; break; + case IS_LONG: + zend_error_noreturn(E_ERROR, "Cannot use integer as array"); + /* break intentionally missing */ + case IS_DOUBLE: + zend_error_noreturn(E_ERROR, "Cannot use float as array"); + /* break intentionally missing */ + case IS_BOOL: + zend_error_noreturn(E_ERROR, "Cannot use boolean as array"); + /* break intentionally missing */ default: if (result) { -- http://www.cristianrodriguez.net