Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:35511
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain zend.com designates 212.25.124.162 as permitted sender)
Message-ID: <47B56334.9070007@zend.com>
Date: Fri, 15 Feb 2008 13:02:28 +0300
User-Agent: Thunderbird 2.0.0.9 (Windows/20071031)
MIME-Version: 1.0
To: jani.taskinen@iki.fi
CC: Marcus Boerger <helly@php.net>, 
 PHP Internals List <internals@lists.php.net>,
 Andi Gutmans <andi@zend.com>
References: <971575499.20080209153315@marcus-boerger.de>	 <47B54F0C.2090700@zend.com> <1203067815.10500.5.camel@localhost.localdomain>
In-Reply-To: <1203067815.10500.5.camel@localhost.localdomain>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] [RFC] Conditional INI support
From: dmitry@zend.com (Dmitry Stogov)



Jani Taskinen wrote:
> On Fri, 2008-02-15 at 11:36 +0300, Dmitry Stogov wrote:
>> a) I think we don't need (1) ternary support at all, as (2) 
>> if-elif=else-endif may do the same.
> 
> That was already dropped. :)
> 
>> b) I think usage of square brackets is not a good idea, because they are 
>> commonly used to divide ini files into sections. Why not to use C 
>> syntax? (#if...)
> 
> I'd prefer that syntax too, it would be much clearer than mixing the
> sections with this. It's also backwards compatible, lines prefixed with
> # are simply ignored.
> 
>> c) We can use just "value" insted of ${value} in conditions.
> 
> Yup. ${foobar} is actually not any "variable" per se, but just a
> reference to existing ini entry in the file. And I don't think that
> needs to change.

Oh, I see. Then we can use just "$string" (or "$str.str") for ini 
entries and "string" for PHP constants. We can also implement defined() 
macro-function, to check if constant defined.

Dmitry.

>> d) I would prefer not to use '.' in the variables name. It will allow to 
>> distribute conditional ini files, and use them with old PHP versions 
>> after manual preprocessing (using cpp).
> 
> . is acceptable since it's acceptable in ini directive names too. And
> works just fine in pre 5.3 versions too.
> 
>> e) We don't need to define special names, we can use internal PHP constants.
> 
> Yup, I mentioned this a couple of times already. :)
> 
> --Jani
>