Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:35457 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 27405 invoked by uid 1010); 13 Feb 2008 21:11:47 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 27389 invoked from network); 13 Feb 2008 21:11:47 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 13 Feb 2008 21:11:47 -0000 Authentication-Results: pb1.pair.com smtp.mail=derick@php.net; spf=unknown; sender-id=unknown Authentication-Results: pb1.pair.com header.from=derick@php.net; sender-id=unknown Received-SPF: unknown (pb1.pair.com: domain php.net does not designate 82.94.239.7 as permitted sender) X-PHP-List-Original-Sender: derick@php.net X-Host-Fingerprint: 82.94.239.7 mail.jdi-ict.nl Linux 2.6 Received: from [82.94.239.7] ([82.94.239.7:57578] helo=mail.jdi-ict.nl) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 14/5F-24174-11D53B74 for ; Wed, 13 Feb 2008 16:11:46 -0500 Received: from localhost (localhost [127.0.0.1]) by mail.jdi-ict.nl (8.13.7/8.12.11) with ESMTP id m1DLBgd8007587; Wed, 13 Feb 2008 22:11:42 +0100 Date: Wed, 13 Feb 2008 22:11:44 +0100 (CET) X-X-Sender: derick@kossu.ez.no To: Stanislav Malyshev cc: "'PHP Internals'" In-Reply-To: <47B35ACD.4090900@zend.com> Message-ID: References: <47AA5354.7020806@zend.com> <47B35ACD.4090900@zend.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=UTF-8 Subject: Re: [PHP-DEV] _REQUEST and variable_order From: derick@php.net (Derick Rethans) On Wed, 13 Feb 2008, Stanislav Malyshev wrote: > > matching GET/POST. I think this should be cleaned up so that _REQUEST > > behavior would conform its use case. > > Attached is the patch that implements request_order .ini value. Comments? Yes... I didn't seem to see a default: + STD_PHP_INI_ENTRY("request_order", NULL, PHP_INI_SYSTEM|PHP_INI_PERDIR,OnUpdateString, request_order, php_core_globals, core_globals) Which means that without this setting, nothing ends up in request. The default should be what it is now ("GPC"). The same is true for php.ini-dist - it should mention the default (still commented out, just like the rest) as "GPC" too. regards, -- Derick Rethans http://derickrethans.nl | http://ezcomponents.org | http://xdebug.org