Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:35436 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 56845 invoked by uid 1010); 13 Feb 2008 08:47:52 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 56824 invoked from network); 13 Feb 2008 08:47:51 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 13 Feb 2008 08:47:51 -0000 Authentication-Results: pb1.pair.com smtp.mail=pierre.php@gmail.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=pierre.php@gmail.com; sender-id=pass; domainkeys=bad Received-SPF: pass (pb1.pair.com: domain gmail.com designates 66.249.82.237 as permitted sender) DomainKey-Status: bad X-DomainKeys: Ecelerity dk_validate implementing draft-delany-domainkeys-base-01 X-PHP-List-Original-Sender: pierre.php@gmail.com X-Host-Fingerprint: 66.249.82.237 wx-out-0506.google.com Received: from [66.249.82.237] ([66.249.82.237:45227] helo=wx-out-0506.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id EC/A1-42926-2BEA2B74 for ; Wed, 13 Feb 2008 03:47:47 -0500 Received: by wx-out-0506.google.com with SMTP id s14so6423181wxc.26 for ; Wed, 13 Feb 2008 00:47:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; bh=DRIga3H1xvgtZ/Hnc/yOyIPsV0PKmN1tXzYJwiq1P6o=; b=mYuDHjtwbC3TumSAew2Jse4RaYRQkzwI4PeBjd31ib0IpdO1wk31kwrvwOaR8vYFx9KjGwet3YrLsnIdmC5mwBdGCL02WfqP43FaQTY1rGX/+RfxVajh1dXcrnczB6Lhe2IiPRK5U+NsH2LZuo+T22Y0C42ZqvI8bFGM4bbLqik= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=LfzUADG/jgN0MtNOZti9qsS7p0PU5YuJtHzPwHzOx3HaCnYlM1eO8HpvEqvRImdDejDpPpt5hMk4gjPmCIW/Ef9LDIvUV9UAA1p4eV+dacCGxyOHJlTFZvca1odjoZUu/7ptWq2b3EYxH7kjZg76xFU8zDuO2yiIxIHzMqFEzik= Received: by 10.141.62.15 with SMTP id p15mr1645480rvk.159.1202892463206; Wed, 13 Feb 2008 00:47:43 -0800 (PST) Received: by 10.141.70.21 with HTTP; Wed, 13 Feb 2008 00:47:43 -0800 (PST) Message-ID: Date: Wed, 13 Feb 2008 09:47:43 +0100 To: "Felipe Pena" Cc: internals@lists.php.net In-Reply-To: <1202868491.5872.53.camel@pena> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline References: <1202861045.5872.37.camel@pena> <1202868491.5872.53.camel@pena> Subject: Re: [PHP-DEV] Math functions (new parameter parsing) From: pierre.php@gmail.com ("Pierre Joye") On Feb 13, 2008 3:08 AM, Felipe Pena wrote: > Em Qua, 2008-02-13 =E0s 01:31 +0100, Pierre Joye escreveu: > > Hi! > > > > On Feb 13, 2008 1:04 AM, Felipe Pena wrote: > > > Hi all, > > > > > > I made a patch for 5_3 where all functions in ext/standard/math.c use > > > the new parameter parsing. (As was done in HEAD) > > > > I think it got lost between you and the list :) > > > > > If anyone think it good, let me know, and then i'll commit it. > > > > > > Several tests break with the patch. Hence, i'll fix them also, if > > > agreed. :) > > > > How do they fail? I worry a bit about BC here. > > There are two cases. > > In most part of it: > 003+ Warning: acos() expects exactly 1 parameter, 2 given ... > 003- Warning: Wrong parameter count for acos() ... Ok, any branch. > And breaking BC: > 010+ > 011+ Warning: acos() expects parameter 1 to be double, string given ... > 012+ NULL > 010- float(1.570796327) > 014+ > 015+ Notice: A non well formed numeric value encountered ... I tend to think to do not break such things in 5.x. But 5.3 sounds like a good opportunity to add a notice about the bad inputs. I can't test the patch right now but does it change the result or only raises a notice? Cheers, --=20 Pierre http://blog.thepimp.net | http://www.libgd.org