Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:35430 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 72489 invoked by uid 1010); 13 Feb 2008 02:09:42 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 72474 invoked from network); 13 Feb 2008 02:09:42 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 13 Feb 2008 02:09:42 -0000 Authentication-Results: pb1.pair.com header.from=felipensp@gmail.com; sender-id=pass; domainkeys=bad Authentication-Results: pb1.pair.com smtp.mail=felipensp@gmail.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.132.250 as permitted sender) DomainKey-Status: bad X-DomainKeys: Ecelerity dk_validate implementing draft-delany-domainkeys-base-01 X-PHP-List-Original-Sender: felipensp@gmail.com X-Host-Fingerprint: 209.85.132.250 an-out-0708.google.com Received: from [209.85.132.250] ([209.85.132.250:44534] helo=an-out-0708.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 0B/F0-36990-56152B74 for ; Tue, 12 Feb 2008 21:09:41 -0500 Received: by an-out-0708.google.com with SMTP id c18so1106736anc.1 for ; Tue, 12 Feb 2008 18:09:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:subject:from:to:cc:in-reply-to:references:content-type:date:message-id:mime-version:x-mailer:content-transfer-encoding; bh=2PIpjUUHb0BkXhOCBaNCJgjdtpu57bcTt7972EvmVvk=; b=iefcDOxq+qhH/pCjxXZmH9uoCJkiTktkLABsRf5XRSAV+FlbxWQ4PewUL5cBVPTw9b4+mPRlovtVbMRdxoPJpHdV2rT315DLSS2JbXlnK8NsfO0taPjjCIVr3tVlgvU/hz+gogx3+siHwndX4IbBhLW1F8Xlf9xdPuPJh8ZgwLo= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=subject:from:to:cc:in-reply-to:references:content-type:date:message-id:mime-version:x-mailer:content-transfer-encoding; b=xJ6FvRo4IchHbAAQfXOJD6QZ9pt0N8DroTVt15kOZtuiuVVOobUK3AIuqIybqk96YrfhRFNN0W2bFTlHpeUpTmQFIPDWiPekWDbQ8bWVsZX6M9c79p9cSnOI+rECDQyWlEbQ7Xe2PO5sRS2yZdg8L2NK4OCEL+v3XnV7ncDm4pA= Received: by 10.100.194.17 with SMTP id r17mr2585959anf.115.1202868579022; Tue, 12 Feb 2008 18:09:39 -0800 (PST) Received: from ?189.24.86.206? ( [189.24.86.206]) by mx.google.com with ESMTPS id m33sm1653134ele.17.2008.02.12.18.09.35 (version=TLSv1/SSLv3 cipher=RC4-MD5); Tue, 12 Feb 2008 18:09:38 -0800 (PST) To: Pierre Joye Cc: internals@lists.php.net In-Reply-To: References: <1202861045.5872.37.camel@pena> Content-Type: text/plain; charset=utf-8 Date: Wed, 13 Feb 2008 00:08:11 -0200 Message-ID: <1202868491.5872.53.camel@pena> Mime-Version: 1.0 X-Mailer: Evolution 2.10.1 Content-Transfer-Encoding: 8bit Subject: Re: [PHP-DEV] Math functions (new parameter parsing) From: felipensp@gmail.com (Felipe Pena) Em Qua, 2008-02-13 às 01:31 +0100, Pierre Joye escreveu: > Hi! > > On Feb 13, 2008 1:04 AM, Felipe Pena wrote: > > Hi all, > > > > I made a patch for 5_3 where all functions in ext/standard/math.c use > > the new parameter parsing. (As was done in HEAD) > > I think it got lost between you and the list :) > > > If anyone think it good, let me know, and then i'll commit it. > > > > Several tests break with the patch. Hence, i'll fix them also, if > > agreed. :) > > How do they fail? I worry a bit about BC here. There are two cases. In most part of it: 003+ Warning: acos() expects exactly 1 parameter, 2 given ... 003- Warning: Wrong parameter count for acos() ... And breaking BC: 010+ 011+ Warning: acos() expects parameter 1 to be double, string given ... 012+ NULL 010- float(1.570796327) 014+ 015+ Notice: A non well formed numeric value encountered ... PS: The same behavior in HEAD. http://felipe.ath.cx/diff/math.diff > Thanks for your work! Thanks for your attention! :) -- Regards, Felipe Pena.