Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:35428
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain zend.com designates 212.25.124.162 as permitted sender)
Content-class: urn:content-classes:message
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Date: Tue, 12 Feb 2008 16:38:43 -0800
Message-ID: <698DE66518E7CA45812BD18E807866CE0142DE4A@us-ex1.zend.net>
Thread-Topic: [PHP-DEV] Re: [ZEND-ENGINE-CVS] cvs: ZendEngine2(PHP_5_3) /zend_compile.c zend_highlight.c zend_language_parser.yzend_language_scanner.l /tests heredoc_001.phpt heredoc_002.phptheredoc_003.phpt heredoc_004.phpt heredoc_005.phpt heredoc_006.phptheredoc
Thread-Index: AchtpZxtirketOEjQz+vrzC7gp8VhAAMusFA
References: <7f3ed2c30802121022q204eabf1wc6277765ceaaf469@mail.gmail.com> <1202841079.10232.11.camel@localhost.localdomain>
To: <jani.taskinen@iki.fi>,
	"Hannes Magnusson" <hannes.magnusson@gmail.com>
Cc: "PHP Development" <internals@lists.php.net>
Subject: RE: [PHP-DEV] Re: [ZEND-ENGINE-CVS] cvs: ZendEngine2(PHP_5_3) /zend_compile.c zend_highlight.c zend_language_parser.yzend_language_scanner.l /tests heredoc_001.phpt heredoc_002.phptheredoc_003.phpt heredoc_004.phpt heredoc_005.phpt heredoc_006.phptheredoc
From: andi@zend.com ("Andi Gutmans")

It's really hard to remember this stuff.
Maybe we should make the system actually validate the messages when they
are committed and reject the commit when tags are missing. For commits
where a certain tag isn't relevant we could have an explicit way to skip
it e.g. [DOC-NONE]. At least that way it's in the back (and front) of
people's mind :)

Andi

> -----Original Message-----
> From: Jani Taskinen [mailto:jani.taskinen@sci.fi]
> Sent: Tuesday, February 12, 2008 10:31 AM
> To: Hannes Magnusson
> Cc: PHP Development
> Subject: Re: [PHP-DEV] Re: [ZEND-ENGINE-CVS] cvs: ZendEngine2(PHP_5_3)
> /zend_compile.c zend_highlight.c
> zend_language_parser.yzend_language_scanner.l /tests heredoc_001.phpt
> heredoc_002.phptheredoc_003.phpt heredoc_004.phpt heredoc_005.phpt
> heredoc_006.phptheredoc
>=20
> Please, when you give such feedback, please point finger at the
persons
> who deserve it. Now it feels like everyone is "misbehaving" here.
> Not only mention the name in the body of the email but Cc: the mail to
> these people. Each and everyone who deserves to get spanked. And I'm
> not
> joking..
>=20
> I myself have forgot to use the damn dog tag many times. (Which is it
> again, @DOC@ or [DOC] ? :) And if I forget, I'd like to be reminded.
>=20
> --Jani
>=20
>=20
> On Tue, 2008-02-12 at 19:22 +0100, Hannes Magnusson wrote:
> > I would really really really really appreciate if the [DOC] tag was
> used more.
> >
> > While only random new features (or whatever requiring docs) are
> tagged
> > with [DOC] it is totally useless as the doc team still has to browse
> > through every single commit to figure out if there is something in
it
> > to document.
> >
> > To make matters worse; some new optional
> parameters/functions/whatever
> > are disguised as bug reports with absurd summary and when they get
> > fixed only "Fixed bug#xxx (foobar)" is added to the commit message
> and
> > NEWS file... you really expect the doc team to actually _read_  the
> > _commit_ and ignoring the commit message?
> >
> > Undocumented features are useless to the "general public". And no,
> > your blog and/or article on/in devzone/php|arch is definitely not
the
> > place to write documentations if you want the feature to be used.
> >
> > On a related note: When reclassifying bug reports as "documentation
> > problem" *please* mention what exactly it is that needs to be
> > documented!
> >
> > Common guys, we can do a lot better here.
> >
> > -Hannes
> >
> > On Feb 12, 2008 10:27 AM, Dmitry Stogov <dmitry@php.net> wrote:
> > > dmitry          Tue Feb 12 09:27:46 2008 UTC
> > >
> > >   Added files:                 (Branch: PHP_5_3)
> > >     /ZendEngine2/tests  heredoc_001.phpt heredoc_002.phpt
> > >                         heredoc_003.phpt heredoc_004.phpt
> > >                         heredoc_005.phpt heredoc_006.phpt
> > >                         heredoc_007.phpt heredoc_008.phpt
> > >                         heredoc_009.phpt heredoc_010.phpt
> > >                         heredoc_011.phpt nowdoc.inc
nowdoc_001.phpt
> > >                         nowdoc_002.phpt nowdoc_003.phpt
> nowdoc_004.phpt
> > >                         nowdoc_005.phpt nowdoc_006.phpt
> nowdoc_007.phpt
> > >                         nowdoc_008.phpt nowdoc_009.phpt
> nowdoc_010.phpt
> > >                         nowdoc_011.phpt nowdoc_012.phpt
> nowdoc_013.phpt
> > >                         nowdoc_014.phpt nowdoc_015.phpt
> > >
> > >   Modified files:
> > >     /php-src    NEWS
> > >     /ZendEngine2        zend_compile.c zend_highlight.c
> zend_language_parser.y
> > >                         zend_language_scanner.l
> > >   Log:
> > >   Added NEWDOC
> > >
> > >
> > > --
> > > Zend Engine CVS Mailing List (http://cvs.php.net/)
> > > To unsubscribe, visit: http://www.php.net/unsub.php
> > >
> >
> --
> Patches/Donations: http://pecl.php.net/~jani/
>=20
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php