Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:35417 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 40275 invoked by uid 1010); 12 Feb 2008 18:14:39 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 40259 invoked from network); 12 Feb 2008 18:14:39 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 12 Feb 2008 18:14:39 -0000 Authentication-Results: pb1.pair.com header.from=jani.taskinen@sci.fi; sender-id=unknown Authentication-Results: pb1.pair.com smtp.mail=jani.taskinen@sci.fi; spf=permerror; sender-id=unknown Received-SPF: error (pb1.pair.com: domain sci.fi from 63.208.196.178 cause and error) X-PHP-List-Original-Sender: jani.taskinen@sci.fi X-Host-Fingerprint: 63.208.196.178 mho-01-bos.mailhop.org Received: from [63.208.196.178] ([63.208.196.178:59089] helo=mho-01-bos.mailhop.org) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id A9/DA-36990-E02E1B74 for ; Tue, 12 Feb 2008 13:14:39 -0500 Received: from [81.22.163.71] (helo=[10.6.109.198]) by mho-01-bos.mailhop.org with esmtpsa (SSLv3:RC4-MD5:128) (Exim 4.68) (envelope-from ) id 1JOzeM-0002MI-US; Tue, 12 Feb 2008 18:14:35 +0000 X-Mail-Handler: MailHop Outbound by DynDNS X-Originating-IP: 81.22.163.71 X-Report-Abuse-To: abuse@dyndns.com (see http://www.mailhop.org/outbound/abuse.html for abuse reporting information) X-MHO-User: U2FsdGVkX1+munqxkK+f4nGcga+AyWV2fJX5tbLgl+8= Reply-To: jani.taskinen@iki.fi To: Pierre Joye Cc: internals Mailing List In-Reply-To: References: <1323006624.20080209143940@marcus-boerger.de> <1202838992.10232.1.camel@localhost.localdomain> Content-Type: text/plain Date: Tue, 12 Feb 2008 20:14:30 +0200 Message-ID: <1202840070.10232.7.camel@localhost.localdomain> Mime-Version: 1.0 X-Mailer: Evolution 2.8.3 (2.8.3-2.fc6) Content-Transfer-Encoding: 7bit Subject: Re: [PHP-DEV] [patch] expose PHP version details as constants From: jani.taskinen@sci.fi (Jani Taskinen) On Tue, 2008-02-12 at 19:05 +0100, Pierre Joye wrote: > On Feb 12, 2008 6:56 PM, Jani Taskinen wrote: > > And for the reasons why they're not needed in 5.2 apply to any other PHP > > version. version_compare() is there for a reason, USE IT! No more > > constants for same thing, thankyouverymuch. > > Read: > > it is easier, faster handier to use than version_compare. It makes > perfectly sense to have them as other pointed out too, they can even > be used in php.ini when the [if] is available. I thought nobody noticed my comment about constants and php.ini usage.. You could still use PHP_VERSION there too. :D But to keep php.ini syntax simple, it's better to just keep on adding more constants in PHP side. ;) .oO(..so this is how it feels like when something comes back and bites you in the ass..) -- Patches/Donations: http://pecl.php.net/~jani/