Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:35415 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 29958 invoked by uid 1010); 12 Feb 2008 17:56:41 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 29942 invoked from network); 12 Feb 2008 17:56:41 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 12 Feb 2008 17:56:41 -0000 Authentication-Results: pb1.pair.com smtp.mail=jani.taskinen@sci.fi; spf=permerror; sender-id=unknown Authentication-Results: pb1.pair.com header.from=jani.taskinen@sci.fi; sender-id=unknown Received-SPF: error (pb1.pair.com: domain sci.fi from 63.208.196.178 cause and error) X-PHP-List-Original-Sender: jani.taskinen@sci.fi X-Host-Fingerprint: 63.208.196.178 mho-01-bos.mailhop.org Received: from [63.208.196.178] ([63.208.196.178:55019] helo=mho-01-bos.mailhop.org) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 57/09-36990-7DDD1B74 for ; Tue, 12 Feb 2008 12:56:39 -0500 Received: from [81.22.163.71] (helo=[10.6.109.198]) by mho-01-bos.mailhop.org with esmtpsa (SSLv3:RC4-MD5:128) (Exim 4.68) (envelope-from ) id 1JOzMx-000J4C-2K; Tue, 12 Feb 2008 17:56:35 +0000 X-Mail-Handler: MailHop Outbound by DynDNS X-Originating-IP: 81.22.163.71 X-Report-Abuse-To: abuse@dyndns.com (see http://www.mailhop.org/outbound/abuse.html for abuse reporting information) X-MHO-User: U2FsdGVkX18M4+YO4aaLNTuHXDXaIpHFdX5qxhQvDjE= Reply-To: jani.taskinen@iki.fi To: Ilia Alshanetsky Cc: Pierre Joye , internals Mailing List In-Reply-To: References: <1323006624.20080209143940@marcus-boerger.de> Content-Type: text/plain Date: Tue, 12 Feb 2008 19:56:32 +0200 Message-ID: <1202838992.10232.1.camel@localhost.localdomain> Mime-Version: 1.0 X-Mailer: Evolution 2.8.3 (2.8.3-2.fc6) Content-Transfer-Encoding: 7bit Subject: Re: [PHP-DEV] [patch] expose PHP version details as constants From: jani.taskinen@sci.fi (Jani Taskinen) And for the reasons why they're not needed in 5.2 apply to any other PHP version. version_compare() is there for a reason, USE IT! No more constants for same thing, thankyouverymuch. --Jani On Mon, 2008-02-11 at 11:35 -0500, Ilia Alshanetsky wrote: > We spoke about this via IM, but its only fair that the answer be > provided via a mailing list as well. > > From my standpoint this is a feature, although a minute one and 5.2 > is not in a feature mode right now, we have 5.3 and PHP 6 for that. > Secondly these constants are of dubious value (besides making code > slightly shorter) since nearly everything they offer can already be > done via the existing PHP_VERSION constant and version_compare. Big > version checks like the ones for 5 vs 6 you don't even need version > compare: > if (PHP_VERSION > 6) etc... > > Therefor, for these two reasons I do not believe we need these > constants in 5.2 branch. > > On 11-Feb-08, at 9:20 AM, Pierre Joye wrote: > > > On Feb 9, 2008 2:39 PM, Marcus Boerger wrote: > >> Hello Pierre, > >> yeah nice idea. I am wondering if you might want to add the cvs > >> tag, too? > >> E.g.: PHP_TAG = 'PHP_5_3' > > > > > > I'll commit the patch later today, I think PHP_BRANCHE sounds better > > than PHP_TAG, or PHP_CVS_TAG (but if we move away from CVS? :-D ) > > > > > > Ilia, I know you see no use of this but is it ok to apply it to 5.2 > > too? > > > > Cheers, > > -- > > Pierre > > http://blog.thepimp.net | http://www.libgd.org > > Ilia Alshanetsky > -- Patches/Donations: http://pecl.php.net/~jani/