Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:35397 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 55842 invoked by uid 1010); 11 Feb 2008 21:25:38 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 55826 invoked from network); 11 Feb 2008 21:25:37 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 11 Feb 2008 21:25:37 -0000 Authentication-Results: pb1.pair.com smtp.mail=stas@zend.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=stas@zend.com; sender-id=pass Received-SPF: pass (pb1.pair.com: domain zend.com designates 212.25.124.162 as permitted sender) X-PHP-List-Original-Sender: stas@zend.com X-Host-Fingerprint: 212.25.124.162 mail.zend.com Windows 2000 SP4, XP SP1 Received: from [212.25.124.162] ([212.25.124.162:9277] helo=mx1.zend.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 65/99-64922-15DB0B74 for ; Mon, 11 Feb 2008 16:25:37 -0500 Received: from us-ex1.zend.com ([192.168.16.5]) by mx1.zend.com with Microsoft SMTPSVC(6.0.3790.3959); Mon, 11 Feb 2008 23:25:37 +0200 Received: from [192.168.16.90] ([192.168.16.90]) by us-ex1.zend.com with Microsoft SMTPSVC(6.0.3790.3959); Mon, 11 Feb 2008 13:25:34 -0800 Message-ID: <47B0BD4A.8050509@zend.com> Date: Mon, 11 Feb 2008 13:25:30 -0800 Organization: Zend Technologies User-Agent: Thunderbird 2.0.0.9 (Windows/20071031) MIME-Version: 1.0 To: Lars Strojny CC: Pierre Joye , internals Mailing List References: <20080210111514.54165ecxih2p5yg4@neo.wg.de> <47AFD90D.4010806@zend.com> <1202730660.3698.9.camel@localhost> <1202743539.3698.11.camel@localhost> <1202747101.3698.14.camel@localhost> <1202748940.3698.25.camel@localhost> <1202749494.3698.26.camel@localhost> In-Reply-To: <1202749494.3698.26.camel@localhost> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-OriginalArrivalTime: 11 Feb 2008 21:25:34.0514 (UTC) FILETIME=[A3274920:01C86CF4] Subject: Re: [PHP-DEV] [patch] expose PHP version details as constants From: stas@zend.com (Stanislav Malyshev) >> and it should be good. Stan, looks ok for you? > > Done: http://lars.schokokeks.org/php/dir-constant-6.diff I'm not sure what happens if zend_dirname returns 0, also what happens if this constant is used in eval(), stream of anything else with non-canonical filename? Except that, looks ok. Some tests won't hurt though :) -- Stanislav Malyshev, Zend Software Architect stas@zend.com http://www.zend.com/ (408)253-8829 MSN: stas@zend.com