Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:35387 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 40917 invoked by uid 1010); 11 Feb 2008 16:58:09 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 40902 invoked from network); 11 Feb 2008 16:58:09 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 11 Feb 2008 16:58:09 -0000 Authentication-Results: pb1.pair.com header.from=pierre.php@gmail.com; sender-id=pass; domainkeys=bad Authentication-Results: pb1.pair.com smtp.mail=pierre.php@gmail.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 64.233.184.232 as permitted sender) DomainKey-Status: bad X-DomainKeys: Ecelerity dk_validate implementing draft-delany-domainkeys-base-01 X-PHP-List-Original-Sender: pierre.php@gmail.com X-Host-Fingerprint: 64.233.184.232 wr-out-0506.google.com Linux 2.4/2.6 Received: from [64.233.184.232] ([64.233.184.232:15368] helo=wr-out-0506.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 73/B6-64922-F9E70B74 for ; Mon, 11 Feb 2008 11:58:09 -0500 Received: by wr-out-0506.google.com with SMTP id c38so4084003wra.17 for ; Mon, 11 Feb 2008 08:58:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; bh=SAlKq8L6OmWbWFAiZ9cZBuNGBOq/uSs2AZPIcz6jTWk=; b=VZkdlsAisxdVI0zNLvDM3S1eQoBriynPdCZD8F9xgGc7EWguqgLevUu/luajWfQ8FoH74I1giPszA0O6PpPYX69lBBBdORZ0jrQuzh0INxvqnKoa5wE2w10Os+hPI+geLylcN6NqOnS3703EdPQF8+ynSCLm4dOi5FzrO9TVLyw= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=JXkXO9sCWFFUZAFuvCG6BsmCccYHcKC7oZKauVjwy75QYX1naQ513KGGltY/P3fC0/JOudT6ZvE2lhII9ZKtc8ODvGkFV6TjkyYCd373AeIusEOuFivZI1ROJWbv9YNAI2O6tfypZrkbm/4wCOSSZZFlAW0bPjyvySUn972ETLg= Received: by 10.140.208.14 with SMTP id f14mr126833rvg.204.1202749084387; Mon, 11 Feb 2008 08:58:04 -0800 (PST) Received: by 10.141.70.21 with HTTP; Mon, 11 Feb 2008 08:58:04 -0800 (PST) Message-ID: Date: Mon, 11 Feb 2008 17:58:04 +0100 To: "Lars Strojny" Cc: "internals Mailing List" , "Stanislav Malyshev" In-Reply-To: <1202748940.3698.25.camel@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <20080210111514.54165ecxih2p5yg4@neo.wg.de> <47AFD90D.4010806@zend.com> <1202730660.3698.9.camel@localhost> <1202743539.3698.11.camel@localhost> <1202747101.3698.14.camel@localhost> <1202748940.3698.25.camel@localhost> Subject: Re: [PHP-DEV] [patch] expose PHP version details as constants From: pierre.php@gmail.com ("Pierre Joye") On Feb 11, 2008 5:55 PM, Lars Strojny wrote: > Hi Pierre, > > Am Montag, den 11.02.2008, 17:42 +0100 schrieb Pierre Joye: > [...] > > Looks better :) > > Thank you! > > > I did not test it but it looks good. Did you run the tests suite? > > > > + dirname = estrndup(filename, strlen(filename)); > > + zend_dirname(dirname, strlen(dirname)); > > > > One strlen can be dropped here. > > Ah, good hint. See http://lars.schokokeks.org/php/dir-constant-5.diff > for the corrected version. One more thing: const size_t filename_len = strlen(filename); and it should be good. Stan, looks ok for you? -- Pierre http://blog.thepimp.net | http://www.libgd.org