Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:35386 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 39619 invoked by uid 1010); 11 Feb 2008 16:55:44 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 39604 invoked from network); 11 Feb 2008 16:55:44 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 11 Feb 2008 16:55:44 -0000 Authentication-Results: pb1.pair.com header.from=lars@strojny.net; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=lars@strojny.net; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain strojny.net designates 85.10.204.248 as permitted sender) X-PHP-List-Original-Sender: lars@strojny.net X-Host-Fingerprint: 85.10.204.248 milch.schokokeks.org Received: from [85.10.204.248] ([85.10.204.248:51825] helo=milch.schokokeks.org) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 40/76-64922-F0E70B74 for ; Mon, 11 Feb 2008 11:55:44 -0500 Received: from [10.22.2.133] (colt-d53d2146.colt.mediaventures.de [::ffff:213.61.33.70]) (AUTH: PLAIN lars@schokokeks.org, SSL: TLSv1/SSLv3,256bits,CAMELLIA256-SHA) by milch.schokokeks.org with esmtp; Mon, 11 Feb 2008 17:55:41 +0100 id 0000000000020003.0000000047B07E0D.000037CB To: Pierre Joye Cc: internals Mailing List In-Reply-To: References: <1323006624.20080209143940@marcus-boerger.de> <20080210111514.54165ecxih2p5yg4@neo.wg.de> <47AFD90D.4010806@zend.com> <1202730660.3698.9.camel@localhost> <1202743539.3698.11.camel@localhost> <1202747101.3698.14.camel@localhost> Date: Mon, 11 Feb 2008 17:55:40 +0100 Message-ID: <1202748940.3698.25.camel@localhost> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=_milch.schokokeks.org-14283-1202748941-0001-2" X-Mailer: Evolution 2.21.5 Subject: Re: [PHP-DEV] [patch] expose PHP version details as constants From: lars@strojny.net (Lars Strojny) --=_milch.schokokeks.org-14283-1202748941-0001-2 Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hi Pierre, Am Montag, den 11.02.2008, 17:42 +0100 schrieb Pierre Joye: [...] > Looks better :) Thank you! > I did not test it but it looks good. Did you run the tests suite? >=20 > + dirname =3D estrndup(filename, strlen(filename)); > + zend_dirname(dirname, strlen(dirname)); > > One strlen can be dropped here. Ah, good hint. See http://lars.schokokeks.org/php/dir-constant-5.diff for the corrected version. cu, Lars --=_milch.schokokeks.org-14283-1202748941-0001-2 Content-Type: application/pgp-signature; name="signature.asc" Content-Transfer-Encoding: 7bit Content-Description: Dies ist ein digital signierter Nachrichtenteil -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.8 (GNU/Linux) iQIcBAABAgAGBQJHsH4LAAoJECQPF+sCY6wH+a8P/RpcIQpou1cfPiSUycBGXagH x3l/l4z3d3iikV2qkl3dC0R3EsEOQ+lV+s8+3ErI4Rc7xZEvOWrLUm/icppOReBr tqH+5bfVcDw/4JmaOLZHfmbshcOoLXbvOHoOPY05KC/in6rY4unPTa5ELzfy09op lG4IwCzGc/diqoFYDZXNx0vJTyzfql6V8qe/E7gTmjTbwWGItBXZ+7X79tylcPu7 hB8bCFnIvf7p5P1WJ4JEy/iGSO0JVRpk0mlVKEigxbOHGhqEbyquEu4U8O1U7Oja XUJ/D3R1ObFGCD6lwXnwdJAzsQuI6NOYp9eWZqlJ0/bi7F+iHUia63CxB3W3ODuh Clhd6xB0I/PLXU0Z8yIyRYHD8blRfjTDf7vzsMPDXOdGoofMdFPIN7TMfGkpIaJB XWbIhRa/A3xmsEHQREQpRk+4/o5WSZkYAEiIHBtBOASb1rMV4SCAlkK+cFZAmSlJ sAuaD0gkJNKrvvwhObM4EsgQqSXTCDAb9ML7+Ok0eLDeytYfq69PRcnp/7XF3tYf UUNxHtxaLYrpGBhQ4ht5jJSuWI3cSVhBU1XwD2XtdDB5B3SzJSGukcSySivO2YyN JQMSJshNYixgVKQBP+OXkRCSSbDI7XOaPuEtPpqJcfBa66ZVC0RC4rfoHo9n022X l6+rE8hDP/rfL0xqhoLW =gxS6 -----END PGP SIGNATURE----- --=_milch.schokokeks.org-14283-1202748941-0001-2--