Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:35384 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 29247 invoked by uid 1010); 11 Feb 2008 16:42:54 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 29232 invoked from network); 11 Feb 2008 16:42:54 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 11 Feb 2008 16:42:54 -0000 Authentication-Results: pb1.pair.com smtp.mail=pierre.php@gmail.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=pierre.php@gmail.com; sender-id=pass; domainkeys=bad Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.198.187 as permitted sender) DomainKey-Status: bad X-DomainKeys: Ecelerity dk_validate implementing draft-delany-domainkeys-base-01 X-PHP-List-Original-Sender: pierre.php@gmail.com X-Host-Fingerprint: 209.85.198.187 rv-out-0910.google.com Received: from [209.85.198.187] ([209.85.198.187:48907] helo=rv-out-0910.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 34/74-64922-D0B70B74 for ; Mon, 11 Feb 2008 11:42:53 -0500 Received: by rv-out-0910.google.com with SMTP id k15so3328911rvb.23 for ; Mon, 11 Feb 2008 08:42:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; bh=xKvaoOCxE5ySu8Ebx4sxEwR5mcXwx6M3/BoaSZae/OQ=; b=AxkFXhPHQfRVbFvC6ImPZhHWJCydqV+Hpj6eCd8qXkXugcK/Hil9kRwds8vXlkKYAdxnRii7AloHN/PaId9NOZupb1fj//OEHZA46d1ToeU3bB/1pYfcHvCTCokajj7YkLJGgjNt1HQ972vmIXWyC9AK0j8F2QHEAtmtX6dmar8= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=W5Jtg9prQdOJdKWS/3xlZGgC5yHFyyovINIwOG15e/Kij4iRKwS7oiYJbw9vI0PkzLMnAtAZTubGYcA5+NkZZ5GI9hcIbGZVzb+4Yh5raMEnaRzSLhLxCmq9AMiZva7itmo+4p1uh1HFgIvqhGI8NFiiCihwj2XuEiChQBzfQV8= Received: by 10.141.167.5 with SMTP id u5mr112511rvo.220.1202748168398; Mon, 11 Feb 2008 08:42:48 -0800 (PST) Received: by 10.141.70.21 with HTTP; Mon, 11 Feb 2008 08:42:48 -0800 (PST) Message-ID: Date: Mon, 11 Feb 2008 17:42:48 +0100 To: "Lars Strojny" Cc: "internals Mailing List" In-Reply-To: <1202747101.3698.14.camel@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline References: <1323006624.20080209143940@marcus-boerger.de> <20080210111514.54165ecxih2p5yg4@neo.wg.de> <47AFD90D.4010806@zend.com> <1202730660.3698.9.camel@localhost> <1202743539.3698.11.camel@localhost> <1202747101.3698.14.camel@localhost> Subject: Re: [PHP-DEV] [patch] expose PHP version details as constants From: pierre.php@gmail.com ("Pierre Joye") Hi Lars, On Feb 11, 2008 5:25 PM, Lars Strojny wrote: > Hi Pierre, > > Am Montag, den 11.02.2008, 17:15 +0100 schrieb Pierre Joye: > [...] > > I did not see the zend_dirname usage (wrong link?) and did not find > > either this function/macro. > > > > I slightly modified it to avoid too much strlen and to do not process > > the string if there is nothing to process. Please find my version of > > your patch as attachment. > > I forgot to add the link, I'm so sorry. > http://lars.schokokeks.org/php/dir-constant-4.diff Looks better :) I did not test it but it looks good. Did you run the tests suite? +=09dirname =3D estrndup(filename, strlen(filename)); +=09zend_dirname(dirname, strlen(dirname)); One strlen can be dropped here. Gr=FC=DFe, --=20 Pierre http://blog.thepimp.net | http://www.libgd.org