Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:35382 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 23012 invoked by uid 1010); 11 Feb 2008 16:35:36 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 22997 invoked from network); 11 Feb 2008 16:35:36 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 11 Feb 2008 16:35:36 -0000 Authentication-Results: pb1.pair.com header.from=ilia@prohost.org; sender-id=unknown Authentication-Results: pb1.pair.com smtp.mail=ilia@prohost.org; spf=permerror; sender-id=unknown Received-SPF: error (pb1.pair.com: domain prohost.org from 209.85.132.249 cause and error) X-PHP-List-Original-Sender: ilia@prohost.org X-Host-Fingerprint: 209.85.132.249 an-out-0708.google.com Received: from [209.85.132.249] ([209.85.132.249:27580] helo=an-out-0708.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 71/43-64922-75970B74 for ; Mon, 11 Feb 2008 11:35:36 -0500 Received: by an-out-0708.google.com with SMTP id c18so999320anc.1 for ; Mon, 11 Feb 2008 08:35:33 -0800 (PST) Received: by 10.100.214.15 with SMTP id m15mr377236ang.25.1202747733443; Mon, 11 Feb 2008 08:35:33 -0800 (PST) Received: from ?192.168.1.133? ( [76.65.228.201]) by mx.google.com with ESMTPS id 32sm10530772aga.20.2008.02.11.08.35.32 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 11 Feb 2008 08:35:32 -0800 (PST) Cc: internals Mailing List Message-ID: To: Pierre Joye In-Reply-To: Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit Mime-Version: 1.0 (Apple Message framework v915) Date: Mon, 11 Feb 2008 11:35:30 -0500 References: <1323006624.20080209143940@marcus-boerger.de> X-Mailer: Apple Mail (2.915) Subject: Re: [PHP-DEV] [patch] expose PHP version details as constants From: ilia@prohost.org (Ilia Alshanetsky) We spoke about this via IM, but its only fair that the answer be provided via a mailing list as well. From my standpoint this is a feature, although a minute one and 5.2 is not in a feature mode right now, we have 5.3 and PHP 6 for that. Secondly these constants are of dubious value (besides making code slightly shorter) since nearly everything they offer can already be done via the existing PHP_VERSION constant and version_compare. Big version checks like the ones for 5 vs 6 you don't even need version compare: if (PHP_VERSION > 6) etc... Therefor, for these two reasons I do not believe we need these constants in 5.2 branch. On 11-Feb-08, at 9:20 AM, Pierre Joye wrote: > On Feb 9, 2008 2:39 PM, Marcus Boerger wrote: >> Hello Pierre, >> yeah nice idea. I am wondering if you might want to add the cvs >> tag, too? >> E.g.: PHP_TAG = 'PHP_5_3' > > > I'll commit the patch later today, I think PHP_BRANCHE sounds better > than PHP_TAG, or PHP_CVS_TAG (but if we move away from CVS? :-D ) > > > Ilia, I know you see no use of this but is it ok to apply it to 5.2 > too? > > Cheers, > -- > Pierre > http://blog.thepimp.net | http://www.libgd.org Ilia Alshanetsky