Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:35378 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 9659 invoked by uid 1010); 11 Feb 2008 16:15:37 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 9632 invoked from network); 11 Feb 2008 16:15:37 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 11 Feb 2008 16:15:37 -0000 Authentication-Results: pb1.pair.com header.from=pierre.php@gmail.com; sender-id=pass; domainkeys=bad Authentication-Results: pb1.pair.com smtp.mail=pierre.php@gmail.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.198.185 as permitted sender) DomainKey-Status: bad X-DomainKeys: Ecelerity dk_validate implementing draft-delany-domainkeys-base-01 X-PHP-List-Original-Sender: pierre.php@gmail.com X-Host-Fingerprint: 209.85.198.185 rv-out-0910.google.com Received: from [209.85.198.185] ([209.85.198.185:3568] helo=rv-out-0910.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id CC/B0-64922-E9470B74 for ; Mon, 11 Feb 2008 11:15:36 -0500 Received: by rv-out-0910.google.com with SMTP id k15so3322245rvb.23 for ; Mon, 11 Feb 2008 08:15:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:references; bh=CGiyd6hKeONyjyE7ShJ4DQ7uqUakFCHWEVfl9dmbS9s=; b=uGt4Wjw3HyPKbpb4qAhu9sYM3MxmdMlsxpbywQGeRc8bTNLjz7/jzh+jiRYrVnfi6CiIthFk3pSX2a9o9Ti3MhDV0WiOVhGJ9dMbRTHT7u1qPDSgo13GNyDkOIU4Xtoux8Kl3DG1tq6ZMKjNqZu/yLoUExoveAs1ekiLvz7wVJU= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:references; b=B6GEGG2KR4d8Z3ENRTXbufy21TWQ0lqCbLHXICUGMYiiwi4+rXnD6TFE3IzR9rjVAxegNGDsrRvIKPpgpckYg4U+z2OrzZk0GZ1LKMM+EVwMS/hH2HnqswRBxxURSdFOdZy+dstUF3mFnKpGjhWtG7T0f+0zojV2/l0Njae2Hh0= Received: by 10.141.18.14 with SMTP id v14mr86148rvi.252.1202746507683; Mon, 11 Feb 2008 08:15:07 -0800 (PST) Received: by 10.141.70.21 with HTTP; Mon, 11 Feb 2008 08:15:07 -0800 (PST) Message-ID: Date: Mon, 11 Feb 2008 17:15:07 +0100 To: "Lars Strojny" Cc: "internals Mailing List" In-Reply-To: <1202743539.3698.11.camel@localhost> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_23791_22173043.1202746507684" References: <1323006624.20080209143940@marcus-boerger.de> <20080210111514.54165ecxih2p5yg4@neo.wg.de> <47AFD90D.4010806@zend.com> <1202730660.3698.9.camel@localhost> <1202743539.3698.11.camel@localhost> Subject: Re: [PHP-DEV] [patch] expose PHP version details as constants From: pierre.php@gmail.com ("Pierre Joye") ------=_Part_23791_22173043.1202746507684 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline On Feb 11, 2008 4:25 PM, Lars Strojny wrote: > Hi, > > Am Montag, den 11.02.2008, 12:51 +0100 schrieb Lars Strojny: > [...] > > [1] http://lars.schokokeks.org/php/dir-constant-2.diff > > Updated version. Moved and renamed php_dirname() to zend_dirname() to > not use PHP internals in the Zend Engine. Fixed a memory leak and added > the TSRM-includes to have some macros/constants defined. > > Comments? Critics? I did not see the zend_dirname usage (wrong link?) and did not find either this function/macro. I slightly modified it to avoid too much strlen and to do not process the string if there is nothing to process. Please find my version of your patch as attachment. Thanks for your work! -- Pierre http://blog.thepimp.net | http://www.libgd.org ------=_Part_23791_22173043.1202746507684 Content-Type: text/plain; name=DIR.txt Content-Transfer-Encoding: base64 X-Attachment-Id: f_fcj86i810 Content-Disposition: attachment; filename=DIR.txt PyB0Cj8gdHoKSW5kZXg6IHplbmRfbGFuZ3VhZ2VfcGFyc2VyLnkKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQpSQ1MgZmls ZTogL3JlcG9zaXRvcnkvWmVuZEVuZ2luZTIvemVuZF9sYW5ndWFnZV9wYXJzZXIueSx2CnJldHJp ZXZpbmcgcmV2aXNpb24gMS4xNjAuMi40LjIuOQpkaWZmIC11IC1wIC1yMS4xNjAuMi40LjIuOSB6 ZW5kX2xhbmd1YWdlX3BhcnNlci55Ci0tLSB6ZW5kX2xhbmd1YWdlX3BhcnNlci55CTI4IERlYyAy MDA3IDEzOjM4OjE5IC0wMDAwCTEuMTYwLjIuNC4yLjkKKysrIHplbmRfbGFuZ3VhZ2VfcGFyc2Vy LnkJMTEgRmViIDIwMDggMTY6MTE6MzUgLTAwMDAKQEAgLTEzMiw2ICsxMzIsNyBAQAogJXRva2Vu IFRfRlVOQ19DCiAldG9rZW4gVF9MSU5FCiAldG9rZW4gVF9GSUxFCisldG9rZW4gVF9ESVIKICV0 b2tlbiBUX0NPTU1FTlQKICV0b2tlbiBUX0RPQ19DT01NRU5UCiAldG9rZW4gVF9PUEVOX1RBRwpA QCAtNjgyLDYgKzY4Myw3IEBAIGNvbW1vbl9zY2FsYXI6CiAJfAlUX0NPTlNUQU5UX0VOQ0FQU0VE X1NUUklORwl7ICQkID0gJDE7IH0KIAl8CVRfTElORSAJCQkJCQl7ICQkID0gJDE7IH0KIAl8CVRf RklMRSAJCQkJCQl7ICQkID0gJDE7IH0KKwl8CVRfRElSICAgCQkJCQl7ICQkID0gJDE7IH0KIAl8 CVRfQ0xBU1NfQwkJCQkJeyAkJCA9ICQxOyB9CiAJfAlUX01FVEhPRF9DCQkJCQl7ICQkID0gJDE7 IH0KIAl8CVRfRlVOQ19DCQkJCQl7ICQkID0gJDE7IH0KSW5kZXg6IHplbmRfbGFuZ3VhZ2Vfc2Nh bm5lci5sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KUkNTIGZpbGU6IC9yZXBvc2l0b3J5L1plbmRFbmdpbmUyL3plbmRf bGFuZ3VhZ2Vfc2Nhbm5lci5sLHYKcmV0cmlldmluZyByZXZpc2lvbiAxLjEzMS4yLjExLjIuMTMK ZGlmZiAtdSAtcCAtcjEuMTMxLjIuMTEuMi4xMyB6ZW5kX2xhbmd1YWdlX3NjYW5uZXIubAotLS0g emVuZF9sYW5ndWFnZV9zY2FubmVyLmwJOSBTZXAgMjAwNyAxNjozMzozNCAtMDAwMAkxLjEzMS4y LjExLjIuMTMKKysrIHplbmRfbGFuZ3VhZ2Vfc2Nhbm5lci5sCTExIEZlYiAyMDA4IDE2OjExOjM2 IC0wMDAwCkBAIC0xNTQzLDYgKzE1NDMsMjUgQEAgSEVSRURPQ19DSEFSUyAgICAgICAoInsiKihb XiRcblxyXFx7XXwoIgogCXJldHVybiBUX0ZJTEU7CiB9CiAKKzxTVF9JTl9TQ1JJUFRJTkc+Il9f RElSX18iIHsKKwljb25zdCBjaGFyICpmaWxlbmFtZSA9IHplbmRfZ2V0X2NvbXBpbGVkX2ZpbGVu YW1lKFRTUk1MU19DKTsKKworCWlmICghZmlsZW5hbWUpIHsKKwkJemVuZGx2YWwtPnZhbHVlLnN0 ci5sZW4gPSAwOworCQl6ZW5kbHZhbC0+dmFsdWUuc3RyLnZhbCA9ICIiOworCX0gZWxzZSB7CisJ CWNvbnN0IGludCBsZW4gPSBzdHJsZW4oZmlsZW5hbWUpOworCQljb25zdCBjaGFyICpkaXJuYW1l ID0gZXN0cm5kdXAoZmlsZW5hbWUsIGxlbik7CisJCXBocF9kaXJuYW1lKGRpcm5hbWUsIGxlbik7 CisKKwkJemVuZGx2YWwtPnZhbHVlLnN0ci5sZW4gPSBzdHJsZW4oZGlybmFtZSk7CisJCXplbmRs dmFsLT52YWx1ZS5zdHIudmFsID0gZXN0cm5kdXAoZGlybmFtZSwgemVuZGx2YWwtPnZhbHVlLnN0 ci5sZW4pOworCX0KKworCXplbmRsdmFsLT50eXBlID0gSVNfU1RSSU5HOworCXJldHVybiBUX0RJ UjsKK30KKwogPElOSVRJQUw+KChbXjxdfCI8IltePyVzPF0pezEsNDAwfSl8IjxzInwiPCIgewog I2lmZGVmIFpFTkRfTVVMVElCWVRFCiAJaWYgKFNDTkcob3V0cHV0X2ZpbHRlcikpIHsK ------=_Part_23791_22173043.1202746507684--